Repository navigation
[menu][checkbox][radio][switch] Share selection indicators, menu item wiring, and checked state mapping - #6166
Open
hoanle0126 wants to merge 1 commit into
Conversation
… wiring, and checked state mapping
hoanle0126
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
November 2, 2026 23:35
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 3m 49s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
zannager
added
the
scope: all components
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu.CheckboxItemIndicator,Menu.RadioItemIndicator,Checkbox.Indicator,Radio.Indicator, and the sharedItemIndicatorused bySelect.ItemIndicatorandCombobox.ItemIndicatorall implement the same transition-mounted<span>indicator pattern (useTransitionStatus+useOpenChangeComplete+useRenderElement). Likewise,Menu.Item,Menu.CheckboxItem, andMenu.RadioItemrepeat the same composite list registration, store subscription, anduseMenuItemwiring, andMenu,Checkbox,Radio, andSwitcheach define their ownchecked->data-checked/data-uncheckedattribute mapper.This PR consolidates those shared patterns:
useSelectionIndicatorinpackages/react/src/utils/ItemIndicator.tsxand reuse it acrossItemIndicator,MenuCheckboxItemIndicator,MenuRadioItemIndicator,RadioIndicator, andCheckboxIndicator(also passingenabled: keepMounted || mountedtouseRenderElementinRadioIndicatorandCheckboxIndicatorso disabled indicators skip prop resolution before returningnull).useRegularMenuItemanduseSelectableMenuIteminpackages/react/src/menu/item/useMenuItem.tsto share the common item setup acrossMenuItem,MenuCheckboxItem, andMenuRadioItem.mapCheckedStateAttributeinpackages/react/src/internals/stateAttributesMapping.tsand reuse it inMenu,Checkbox,Radio, andSwitch.Public props, state types, and runtime behavior remain unchanged.
Bundle size
Measured locally on
master(cf696d6) vs. this branch usingbundle-size-checker(all values in bytes):@base-ui/react@base-ui/react/menu@base-ui/react/context-menu@base-ui/react/menubar@base-ui/react/checkbox@base-ui/react/radio@base-ui/react/radio-group@base-ui/react/switch@base-ui/react/select@base-ui/react/combobox