Repository navigation
Conversation
Removes the `AP3A\.240617\.008` crawler entry and its ordinary Instagram example. Adds a regression test asserting that this Android user agent is not classified as a crawler. Fixes monperrus#466
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ordinary Android 15 Instagram traffic is classified as the 80legs scraper because its user agent contains the platform build identifier
AP3A.240617.008.The crawler pattern treated a common Android platform fingerprint as a unique 80legs identifier, so any matching handset traffic was flagged as a crawler.
Summary
Removes the
AP3A\.240617\.008crawler entry and its ordinary Instagram example. Adds a regression test asserting that this Android user agent is not classified as a crawler.How it was tested
The test suite could not be collected because the
crawleruseragentsmodule was unavailable. The tests intest_harness.pyfail without the fix in the crawler-user-agents change (checked by reverting the source changes).Closes #466