Repository navigation
docs: opisz prywatne zgłaszanie luk - #46
Merged
Merged
Conversation
There was a problem hiding this comment.
Independent snapshot review of 1587ccd7f182...40c5a1cc68ee in mikomiel/HowToLiveBetter-PL by pi on opencodex (gpt-6.1-sol).
Verdict: APPROVE
Reviewer output
Findings
No concrete, reachable failures found in the complete diff for 1587ccd7f182c2952b0a2900e6fc85358f713cd5...40c5a1cc68ee7050651d48fb446b91e3a8c012ce.
SECURITY.md:3–6directs reader, site-build and repository-automation vulnerabilities to GitHub’s private-reporting URL formikomiel/HowToLiveBetter-PL, not the upstream repository. It requests reproduction details and explicitly keeps vulnerability details in the private report.SECURITY.md:8–9separately directs content, translation and source feedback to this repository’s Issues.- The change is limited to the nine-line policy. It adds no secret values, dependencies, executable code, permissions or reporting form to the reader.
- Reader scope is preserved:
tools/pl/build-site.mjspublishes an explicit file allowlist plus registered chapters; this addition does not enter that list or change the reader’s fail-closed parsing and publication behaviour. - The supplied PR title follows Conventional Commits (
docs:), and the diff is a small, complete documentation change.
Optional suggestion
At SECURITY.md:5–6, explicitly requesting synthetic or redacted example data would reinforce the existing privacy guidance in README.md.
Validation and limitations
- Read the complete supplied diff and relevant policy, reader, build and test source.
- NOT_RUN: dependency installation, unit tests and browser tests. The PR’s reported results were not independently reproduced; inspected tests are not execution evidence.
- UNAVAILABLE: live GitHub settings and authenticated reporting UI. The URL has the correct repository-specific form, but the snapshot cannot establish that private vulnerability reporting is enabled and usable. The owner should confirm this separately.
- No changed material was unreadable.
VERDICT: APPROVE
Evidence: not written. This review is evidence, not merge authorization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zmiana
Dodaje dokument
SECURITY.mdz odsyłaczem do prywatnego formularza GitHuba dla luk w czytniku, budowaniu strony i automatyzacji repozytorium. Uwagi do treści mają odsyłacz do GitHub Issues.Sprawdzenie
npm ci --ignore-scriptsinpm testprzeszły. W próbie lokalnej przeszło 116 przypadków przeglądarkowych. Cztery przypadki Firefoksa i WebKit wymagają bibliotek dostępnych w środowisku CI. Pełny zestaw sprawdzi GitHub.