Repository navigation
Promote conda to On-by-default - #1904
Merged
Ryan Brandenburg (ryanbrandenburg) merged 1 commit intoOct 27, 2026
Merged
Conversation
Ryan Brandenburg (ryanbrandenburg)
requested a review
from a team
as a code owner
October 26, 2026 17:09
Ryan Brandenburg (ryanbrandenburg)
requested review from
Aayush Maini (AMaini503)
and
a balanced review from Copilot
October 26, 2026 17:09
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused promotion consistently updates detector status, experiment wiring, regression assertions, and documentation, with no blocking issues identified in static review.
No open issues 🎉
What changed in this PR
Promotes the Conda lockfile detector from experimental to stable, making its detected dependencies part of normal scan results.
Changes:
- Removes the experimental marker and increments the detector version to 5.
- Deletes the Conda experiment configuration and its service registration.
- Updates regression tests and documentation to reflect stable, default-on status.
| File | Description |
|---|---|
| test/Microsoft.ComponentDetection.Orchestrator.Tests/Experiments/ExperimentConfigTests.cs | Verifies CondaLock is not in an experiment group. |
| test/Microsoft.ComponentDetection.Detectors.Tests/ComponentDetectorTests.cs | Verifies CondaLock is neither experimental nor default-off. |
| src/Microsoft.ComponentDetection.Orchestrator/Extensions/ServiceCollectionExtensions.cs | Removes the Conda experiment registration. |
| src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/CondaLockDetectorExperiment.cs | Deletes the retired experiment configuration. |
| src/Microsoft.ComponentDetection.Detectors/conda/CondaLockComponentDetector.cs | Removes experimental status and bumps the version. |
| docs/detectors/README.md | Lists CondaLock as stable. |
Review effort: Balanced
Jeff Mendoza (jeffmendoza)
approved these changes
Oct 26, 2026
Ryan Brandenburg (ryanbrandenburg)
merged commit Oct 27, 2026
6e7a4b7
into
main
13 of 18 checks passed
Ryan Brandenburg (ryanbrandenburg)
deleted the
users/rybrande/CondaLockDefaultOn
branch
October 27, 2026 20:51
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conda has been on-by-default for a while without issue, time to promote it to Stable.