Repository navigation
Fix failed typed casts without changing the original value - #956
Closed
guptapratykshh wants to merge 1 commit into
Closed
guptapratykshh wants to merge 1 commit into
guptapratykshh wants to merge 1 commit into
Conversation
guptapratykshh
marked this pull request as ready for review
November 11, 2026 19:40
Member
|
I'm not gonna review anything that has not been discussed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I fixed the typed
metacall_value_cast_*helpers so an unsupported cast returns0orNULLwithout reading the original value as the requested type. The original value remains available to the caller. I added a regression test for failed string-to-int and string-to-pointer casts. No new dependencies.Fixes #933