Repository navigation
Run combined coverage of all Python versions in the pre-push tox hook - #1027
Conversation
|
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryCombines coverage from the tox test runs in the
Acknowledged intent: mauvilsa explicitly limits the warning to complete Python runs so contributors with missing interpreters do not receive a misleading warning. Reviews (1) · Last reviewed commit: "Run combined coverage of all Python vers..." · Reviewed by Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 10018 10018
=========================================
Hits 10018 10018 ☔ View full report in Codecov by Harness. |



What does this PR do?
Makes the
pre-pushhooks produce a coverage report combined from all supported Python versions, in a single tox run. Previously tox ran all versions without coverage, a separate hook ran the tests again to get coverage for only the current Python version, and a full coverage report needed yet another manual tox run.The combined report is shown in the terminal, listing only files below 100%, and is also written as html. A warning is printed if coverage is below 100%, but only when all supported Python versions ran, so that contributors without every version installed don't get a misleading warning. The separate coverage hook, the tox
coveragelabel and the manual steps in the contributing guide are removed, since they are no longer needed.Before submitting