Repository navigation
Conversation
|
@YIOYIOIOI is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 18.1.1 (
cdbdc012)Markdown flavor: n/a (CLI configuration)
Description
The CLI awaits loading a config module but ignores the Promise returned by an exported config function. A function that defers extension setup can therefore finish after parsing, or never finish because the CLI exits first. Initialization failures also produce successful output and exit status 0.
For example, this config should enable line breaks before rendering:
For input
line1\nline2, master emits<p>line1\nline2</p>instead of<p>line1<br>line2</p>.Await the config callback in
runConfig()so setup finishes before parsing and rejected callbacks reach the existing CLI error handler. Document the behavior and add regressions for asynchronous setup and rejection, plus a synchronous callback control. The asynchronous tests launch the actual CLI in separate processes to check output and exit status.Validation
npm testpasses on Windows with Node 24.18.0: 1,911 spec executions, 202 unit tests, documentation build, UMD/CJS checks, type/export checks, and ESLint.git diff --checkpasses.Contributor
Committer