Repository navigation
Carry compact volume labels into the next unit at 1,000 - #72
Merged
seanxwzhang merged 1 commit intoOct 30, 2026
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
seanxwzhang
enabled auto-merge (squash)
October 30, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locale.compact and Locale.volume choose the unit before rounding, so values just under a boundary render as "1,000.0K" (e.g. a 999,960 volume histogram tag) or "1,000.0M" instead of "1.00M" / "1.0B". The unit thresholds now start at 999.95K and 999.95M, the point where the smaller unit would round to 1,000. Added cases to common/chart-core/tests/unit/locale.test.ts that fail on main and pass with the fix;
npm testandnpm run typecheckin common/chart-core pass (994 tests).