Skip to content

Clarify TradingView account choices in Data Providers - #71

Merged
seanxwzhang merged 2 commits into
mainfrom
fix/tradingview-account-choice
Oct 27, 2026
Merged

seanxwzhang merged 2 commits into
mainfrom
fix/tradingview-account-choice

Conversation

@seanxwzhang

@seanxwzhang seanxwzhang commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Turning on TradingView without a connected account offers a choice to connect the user's account or continue with public data. Switch account first opens a short preparation step so users can select their account in their normal browser before authorizing OpenChart. The existing connection stays active until replacement succeeds.

Account actions preserve provider enablement unless they came from an explicit enable request. A failed settings save after successful authorization cannot replay the consumed login link. Account-status read failures do not block provider enablement, and settings read failures retain the existing Retry action and logo credit.

The Elbstream credit is a compact, muted Logos: Elbstream link at the bottom right inside the Data Providers card, retaining the free service's minimum attribution size of 12pt (16 CSS pixels).

Validation:

  • Required CI checks: public content, lint/formatting, workspace types, core tests and app tests.
  • 42 focused account/provider tests, scoped lint, and full workspace typecheck.
  • Packaged Electron UI smoke with controlled authentication responses and real isolated Config writes, including both failed-read/retry cases, desktop and 400px responsive layouts, and attribution placement/text size.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T23:12:07.620732Z cdb8648 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 122885a200

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

devin-ai-integration[bot]

This comment was marked as resolved.

@seanxwzhang
seanxwzhang merged commit 722b2c7 into main Oct 27, 2026
6 checks passed
@seanxwzhang
seanxwzhang deleted the fix/tradingview-account-choice branch October 27, 2026 23:22
@seanxwzhang

Copy link
Copy Markdown
Contributor Author

Thanks for the review and feedback on the account flow and attribution layout. Both read-failure cases are fixed, and this is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant