Repository navigation
Clarify TradingView account choices in Data Providers - #71
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 122885a200
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Thanks for the review and feedback on the account flow and attribution layout. Both read-failure cases are fixed, and this is now merged. |
Turning on TradingView without a connected account offers a choice to connect the user's account or continue with public data. Switch account first opens a short preparation step so users can select their account in their normal browser before authorizing OpenChart. The existing connection stays active until replacement succeeds.
Account actions preserve provider enablement unless they came from an explicit enable request. A failed settings save after successful authorization cannot replay the consumed login link. Account-status read failures do not block provider enablement, and settings read failures retain the existing Retry action and logo credit.
The Elbstream credit is a compact, muted Logos: Elbstream link at the bottom right inside the Data Providers card, retaining the free service's minimum attribution size of 12pt (16 CSS pixels).
Validation: