Skip to content

Add TradingView as a shared data provider with browser sign-in - #69

Merged
seanxwzhang merged 3 commits into
mainfrom
seanxwzhang/TV-as-provider
Oct 27, 2026
Merged

seanxwzhang merged 3 commits into
mainfrom
seanxwzhang/TV-as-provider

Conversation

@seanxwzhang

@seanxwzhang seanxwzhang commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

TradingView is now a shared data provider for charts, Watchlists, Tea, agent tools and alerts. Users connect through their usual browser, including existing Google sessions and passkeys, then paste the one-time login link into OpenChart.

  • Add provider-owned symbol search, futures contract expansion, paged history and live bars through the existing Dataset and Feed contracts. Preserve exchange identity, missing values and source-reported delay.
  • Store the browser session through Credential and validate it before authenticated requests. OAuth completion reports success only after credentials are persisted; expired, cancelled and concurrent duplicate attempts cannot report false success.
  • Support tradingview:VENUE:SYMBOL in Tea and request.security. Search live sources from agent tools so a saved match from another provider cannot hide TradingView.
  • Make retired live streams return the existing retryable reconfiguration error, use split-adjusted defaults, and reject listings that omit their exchange. Preserve the fired event's identity in Trigger-to-Agent context and venue/empty currency in the research workflow template.
  • Keep history uncached until TradingView establishes finality, and compare socket receipt order so older buffered bars cannot roll back a later snapshot. Preserve per-bar deduplication for chronological Tea consumers.
  • Simplify provider settings and login instructions, and show exchange information in symbol results.

Validation:

  • just check passed, covering schema drift, lint, formatting, workspace typechecks, core, app and Feed tests.
  • Regression tests cover delayed revisions, newly published intervals, receipt order across history/live sockets, corrections before snapshot completion, and repeated older bars in live batches.
  • just desktop-package development passed, with native desktop verification.
  • Authenticated checks covered BTCUSD, NQ1! and SPX discovery/history, SMA values checked against independent arithmetic, live updates, saved Alert/Trigger execution, and reconfiguration followed by successful resubscription.
  • The packaged app also passed Tea request.security binding and formula retry after provider refresh.

TradingView's protocol is undocumented; exchange permissions, delay and history availability remain source-dependent. Receipt order is local to the client, not an upstream revision guarantee. Uncached history makes fresh requests on subsequent reads. This provider supplies bars and symbology, without full-catalog indexing or a trading-calendar feed. Existing user-owned workflow copies are preserved.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T20:37:28.870192Z a442363 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@seanxwzhang
seanxwzhang merged commit 5da89f2 into main Oct 27, 2026
6 checks passed
@seanxwzhang
seanxwzhang deleted the seanxwzhang/TV-as-provider branch October 27, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant