[Piotr1215]

Summary

Repeated PR signals can recreate a backport after its prior PR merges or after a run leaves a branch without a PR. Check existing ports and use a stable branch name before writing.

Test plan

• Jest suite, lint, build, and diff check
• Regression tests cover replay, merged PRs, pagination, target branches, concurrent branch creation, and lookup failures

Related to DEVOPS-1803

[djwfyi]

These are the same two issues raised in the forwardport PR review, both of which were addressed there in a924c31:

• [P1] Retries skip unfinished backports (src/index.ts:184–187). The branch is created before file processing and PR creation. If either fails, the leftover branch causes every retry to skip the version and report success without completing the backport. Please allow recovery of unfinished work while preserving concurrency protection.
• [P2] The PR lookup stops working at 10,000 closed PRs (src/index.ts:1136–1137). The search scans all repository PRs and throws after 100 full pages, so new backports without an existing match fail once that threshold is reached. Please paginate until exhaustion or narrow the lookup.

Reviewed commit 449fd978dd2a996cc627c45ad60c246fd3adb22e. The existing 83 tests, lint, and build pass with locally installed dependencies. Three additional regression checks reproduce the failures: retry after a file-write error, retry after a PR-creation error, and lookup with 10,000 unrelated closed PRs.

[Piotr1215]

Addressed review 5879818809 in 57aa60d.

1. P1: Retries resume the existing branch. GitHub's merge base restores the original folder layout and version-specific rename content after earlier deletions. A destination written by a failed attempt is accepted only when it was absent at the base and its bytes match the intended write. Prior branch changes also trigger PR creation when a retry has no new writes. An atomic lock ref serializes writers, including concurrent resumes, and the PR lookup runs again inside the lock.
2. P2: The REST pull-request listing now paginates until exhaustion. The fixed 100-page ceiling is removed, with a regression that finds a matching closed PR after 10,000 unrelated results. Legacy title matching and lookup failure handling are preserved.

Validation: 93 tests pass, including interrupted file writes, failed PR creation, folder deletion/replacement, partial and completed renames, real destination conflicts, concurrent deliveries, and page 101. Eight recovery regressions failed against 449fd97 before the fix. Lint, build, explicit source ESLint, and diff checks pass; dist/index.js is rebuilt.

The README covers hard cancellation: handled failures release the lock, but a killed runner can leave it behind. Confirm that its writers have stopped before removing that lock and rerunning. Recovery branches stay owned by the action so their merge base remains stable.

[djwfyi]

Both reported issues are resolved in 57aa60d. Failed attempts resume safely under the writer lock, and the PR lookup paginates until exhaustion.

Validation: all 93 tests, lint, and build pass with locally installed dependencies. Three additional checks also pass for modified-file recovery, interrupted content-changing rename recovery preserving version-specific content, and lock release when the inner PR lookup finds an existing PR. No further actionable findings.