Repository navigation
Conversation
|
👋 Hi! I see this is a draft PR. |
Contributor
|
I think supplying dependencies to Maybe there is another solution? Or the needed change can be done upstream? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1070
Summary
EsploraHeaderProviderand an additive builder method for runtime headers.Design notes
The two client paths use different
esplora-clientversions, so this vendors and patches both versions with a per-request provider hook. UniFFI 0.29 cannot export async foreign callback traits; its provider callback is synchronous and should return the application's current cached headers promptly.The builder's custom
Debugimplementation also redacts the Bitcoin Core RPC password.OpenAI Codex assisted with implementation and validation.