Skip to content

docs(tokens): approving a desktop app sign-in needs Create Token in any of your organizations - #1348

Merged
leecalcote merged 1 commit into
masterfrom
fix/native-signin-create-token-any-org
Oct 19, 2026
Merged

leecalcote merged 1 commit into
masterfrom
fix/native-signin-create-token-any-org

Conversation

@leecalcote

@leecalcote leecalcote commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Approving a desktop app or CLI sign-in now checks Create Token in at least one organization you belong to, not the selected organization or the custom domain's organization. Companion to the layer5io/meshery-cloud fix for native sign-in on custom domains.

Summary by CodeRabbit

  • Documentation
    • Clarified that approving a desktop app or CLI sign-in requires the Create Token key in at least one organization the user belongs to, regardless of the selected organization or custom domain.

…ny of your organizations

Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@leecalcote leecalcote added the area/docs Improvements or additions to documentation label Oct 19, 2026
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d9beb82f-d949-4ea2-b8b5-73f950e9d33d
📥 Commits

Reviewing files that changed from the base of the PR and between 36d28ca and 6b80c83.

📒 Files selected for processing: 1
  • content/en/cloud/concepts/identity-and-security/tokens.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The token documentation now states that approving a desktop app or CLI sign-in requires Create Token access in at least one organization the user belongs to. The selected organization and a custom domain’s organization do not affect this check.

Changes: Token sign-in approval requirement

Layer / File(s) Summary
Document the approval requirement
content/en/cloud/concepts/identity-and-security/tokens.md
The documentation changes the requirement from access in the selected organization to access in any organization the user belongs to. It clarifies that the selected organization and a custom domain’s organization do not affect the check.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: simihablo

Merge Risk: ⚪ Minimal · up to 6b80c

This documentation-only change has no confirmed merge-blocking risk, although the companion authorization behavior remains unverified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the documented permission change for approving desktop app sign-ins. It accurately states that Create Token permission can exist in any organization the user …
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title clearly and concisely describes the documented permission change for approving desktop app sign-ins. It accurately states that Create Token permission can exist in any organization the user belongs to.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1348/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

@leecalcote
leecalcote merged commit f15e13d into master Oct 19, 2026
7 of 8 checks passed
@leecalcote
leecalcote deleted the fix/native-signin-create-token-any-org branch October 19, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Improvements or additions to documentation component/cloud-docs component/kanvas-docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant