Repository navigation
feat(ingest): coordinate bounded materializer workers with etcd leases - #455
Merged
Merged
Conversation
beinan
force-pushed
the
codex/wal-ingest-http
branch
from
October 21, 2026 23:02
df2070a to
e199493
Compare
beinan
force-pushed
the
codex/wal-ingest-worker
branch
from
October 21, 2026 23:02
574cd5d to
483d4cc
Compare
beinan
force-pushed
the
codex/wal-ingest-http
branch
from
October 22, 2026 02:54
e199493 to
41822bf
Compare
beinan
force-pushed
the
codex/wal-ingest-worker
branch
from
October 22, 2026 03:45
db4e752 to
9e4064c
Compare
beinan
added a commit
that referenced
this pull request
Oct 22, 2026
Initialize a managed rollout generation in Lance and the durable WAL catalog using persisted operation identities. Retrying after a crash reuses the original genesis manifest; initialization rejects an existing foreign table instead of adopting or overwriting it. The regression tests use real Lance files and replicated WALs, including a restart after the genesis file exists but before catalog selection. Focused ingestion/bootstrap tests, feature Clippy, and the complete repository checks pass (Python: 229 passed, 2 skipped, 1 xfailed). Refs #378. Built on merged #455. The feature diff is unchanged when moved to main; all final-commit CI checks must pass before merging. Independent Raft-log recovery cases exclude sibling subprocess-creation windows, preventing inherited file locks from racing immediate reopen. The two-group concurrent-write case and real SIGKILL, rotation, and write-error assertions remain unchanged. All nine Raft-log cases pass with minimal and all features, and Clippy passes. This adjustment changes only test scheduling. TLS process startup failures include the child stdout/stderr and identify peer/image listener binding errors. The unchanged quorum, snapshot-interruption, SIGKILL and full-restart assertions pass in five complete peer-transport library runs (126 tests per run), plus six process tests and feature Clippy. The intermittent CI startup failure has not been reproduced locally; these diagnostics do not establish its root cause. Final-head CI remains required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coordinate materializer processes with bounded etcd claims and durable WAL publisher epochs. A worker reads the WAL epoch before validating its claim, so an expired owner cannot steal a successor's newer epoch. Prepared Lance files survive ownership changes and can be reused exactly.
Workers share memory and WAL client pools, bound concurrent tables and publication rounds, and join admitted file work and lease renewal on shutdown. Busy-table probes use a local, keys-only hint before attempting a lease, avoiding quorum barriers and replicated grant/revoke writes on occupied-table polls. Ownership still requires the linearizable create-if-absent transaction, and claim validation remains linearizable. Managed readers can open the selected Lance version without acquiring publisher ownership.
Assignments are an application-authorized fixed set. Dynamic namespace discovery, application process startup, and sustained throughput qualification are follow-up work.
Refs #378. Built on merged #453. The feature diff is unchanged when moved to main; all final-commit CI checks must pass before merging.
Testing
These are correctness checks. They do not establish process-kill recovery or sustained throughput for the application.
CI runs the existing workspace, WAL, Lance, and etcd suites in separate jobs so cold feature builds do not exhaust one shared 60-minute timeout. Every original check command and the coverage jobs are preserved. Checkpoint reopen cases are serialized around subprocess creation to prevent inherited file locks; corruption cases must report the expected validation error. Minimal-feature and all-feature checkpoint tests and Clippy pass; the workflow passes actionlint. Final-commit CI is required before merging.
Independent Raft-log recovery cases exclude sibling subprocess-creation windows, preventing inherited file locks from racing immediate reopen. The two-group concurrent-write case and real SIGKILL, rotation, and write-error assertions remain unchanged. All nine Raft-log cases pass with minimal and all features, and Clippy passes. This adjustment changes only test scheduling.
TLS process startup failures include the child stdout/stderr and identify peer/image listener binding errors. The unchanged quorum, snapshot-interruption, SIGKILL and full-restart assertions pass in five complete peer-transport library runs (126 tests per run), plus six process tests and feature Clippy. The intermittent CI startup failure has not been reproduced locally; these diagnostics do not establish its root cause. Final-head CI remains required.