Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b001cb6f4c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ] | ||
| zarr_v2 = [ # remove for lamindb v3 | ||
| "numcodecs<0.16.0", # 0.16.0 breaks zarr<3.0.* | ||
| "numcodecs>=0.15.2,<0.16.0", # 0.16.0 breaks zarr<3.0.* |
There was a problem hiding this comment.
On Python 3.10, which this package still advertises via requires-python = ">=3.10" and its classifier, installing lamindb-core[zarr_v2] now becomes unresolvable because Numcodecs 0.15.2 requires Python 3.11 or newer. Either update the package's supported-Python metadata or provide/document a secure Python 3.10-compatible dependency strategy so a nominally supported environment does not fail during extra installation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
we should document clearly that Zarr now requires Python 3.11+
There was a problem hiding this comment.
hm, maybe we drop python=3.10? @falexwolf what do you think?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4051 +/- ##
==========================================
- Coverage 93.92% 89.79% -4.14%
==========================================
Files 93 93
Lines 19333 19384 +51
==========================================
- Hits 18158 17405 -753
- Misses 1175 1979 +804
🚀 New features to boost your workflow:
|
|
Deployment URL: https://0b58ea21.lamindb.pages.dev |
Reject vulnerable Numcodecs versions before Zarr access and raise the Zarr v2 dependency minimum. Patched codecs block implicit pickle decoding for eager and backed reads (upstream advisory). Hosted runtime updates: https://github.com/laminlabs/laminhub/pull/6645.
Compatibility: Zarr users need patched Numcodecs and Python 3.11+. Trusted pickle data requires upstream opt-in.