Repository navigation
Casts of one-bit BIR values in SMT-LIB - #226
Open
didriklundberg wants to merge 1 commit into
Open
didriklundberg wants to merge 1 commit into
didriklundberg wants to merge 1 commit into
Conversation
…tested against bir_eval_exp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SMT-LIB export did not properly implement casts of one-bit BIR values (
Imm1constants,Bit1variables, comparison results). This fix is needed to export proof obligations related to e.g.sltiu rd, rs, 1.The SMT-LIB export now emits
(ite b (_ bv1 N) (_ bv0 N))for aBoolcast to N > 1 bits (the N=1 case is just theBoolunchanged).A new test file has also been added to validate the fix and to use in CI.