Repository navigation
RISC-V lifter: compressed instructions, fences and atomics - #221
Conversation
There was a problem hiding this comment.
@didriklundberg could you add some small "smoke test" example of a RISC-V program with compressed instructions being lifted via lift_da_and_store? Maybe copy one of the simpler ones in examples/riscv like swap to swap_compressed and only have swapScript.sml.
That would increase confidence that the existing machinery works with the extensions.
palmskog
left a comment
There was a problem hiding this comment.
This looks good in general, but could we have an example compressed program that's lifted (and can hopefully be verified), see suggestion on how to cobble that together quickly.
Co-authored-by: Karl Palmskog <palmskog@gmail.com>
That's easily done, but are you sure you want more than the instructions added to selftest_riscv.sml? I am planning to do a larger example later anyway, so might as well avoid clutter. |
|
@didriklundberg but can't we have a small example, possibly even with compilation commands documented in README? selftests are one thing, but an "integration test" would build confidence in the changes. See also the conflict due to merging the misc fixes. |
Sure, let's add a small example. I'll also sort the conflict. |
c8194df to
8de163a
Compare
|
@didriklundberg I will merge this when CI concludes, heads up that I just changed |
|
Failure is CI timeout, merging. |
Additions to the RISC-V lifter:
FENCEandFENCE.I(lifts to no-ops)LR.W/LR.DThere are some other additions coming up that requires updating the RISC-V L3 model, I will make separate PRs for that later.