Repository navigation
eqn writer: escape " and \ in quoted text - #298
Merged
Merged
Conversation
The writer wraps text in the double quotes eqn uses for literal text but emitted the content unescaped, so a `"` ended the string early and a `\` began a troff escape sequence. Closes jgm#297. Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Looks good, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeEqnwraps text in the double quotes eqn uses for literal text, but passed the content through unescaped: a"ends the string early, a\starts a troff escape. pandoc 3.9.0.2 + groff 1.24.1:Adds
quoteText("->\",\->\[rs]) at the three sites that already emit quotes:EText,EMathOperator, andEDelimited'sLeftseparators. Starmath and typst already guard here (escapeQuotes,needsEscape '"').Eleven eqn goldens changed because they recorded the broken output: ms-16 had
roman ""string"" = ..., and complex3 had a"\"delimiter that makes eqn abort withnewline before end of quoted text. Every change is one of the two escapes, nothing else.Scope limit: unquoted output (
EIdentifier,ENumber, bareESymbol) can still emit a raw". Left alone, since quoting it would change how it is typeset.Ran
cabal v2-test: 3154/3154, no new warnings, on GHC 9.14.1 (outside your CI matrix). Against master'sEqn.hsthe new297.testplus 11 goldens fail; escaping only"still fails 10. Roundtrip suite is 943/1683 before and after.AI-assisted, reviewed and verified by me; trailer form follows 05b23da.