Repository navigation
fix(ui): gallery permission guidance, link feedback, Android-only APK entry - #11
Merged
Merged
Conversation
- Gallery permission denial now offers a "去设置" action (app_settings) instead of a dead-end snackbar, on the image long-press menu, long-image export and full-screen mermaid export - External link taps no longer fail silently: canLaunchUrl misses and launch errors surface a hint; mailto:/tel:/sms links now hand off to the system handler - The about page's "download latest APK" entry is Android-only — on iOS it pointed users at a file they cannot install Complex iOS findings were filed separately: iOS libgit2 CA bootstrap (#10) and the security-scoped local-folder gap (comment on #7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Low-cost fixes from the iOS device acceptance audit (three subagent sweeps over Android/iOS divergence, every finding file:line-verified):
app_settings) instead of a bare snackbar, in all three entry points: image long-press menu, long-image export, full-screen mermaid export (lib/src/ui/image_actions.dart:97,lib/src/ui/markdown_viewer.dart:828/2858).canLaunchUrlmisses andlaunchUrlerrors now surface a hint;mailto:/tel:/sms:links hand off to the system handler instead of being silently dropped (lib/src/ui/markdown_viewer.dart_onLinkTap).lib/src/ui/settings/about_page.dart).Complex findings filed separately: #10 (iOS libgit2 CA bootstrap missing), #7 comment (security-scoped resource + bookmark persistence gap).
Test plan
flutter analyze— no issuesflutter test— 246 tests passed