Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions __tests__/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -1024,6 +1024,43 @@ function runBaseTest(
})

describe("slice()", () => {
test.each([
[0, undefined, 2],
[1, 5, 1],
[-4, -1, 1]
])(
"preserves sparse slots for slice(%s, %s)",
(start, end, index) => {
const items = new Array(5)
items[2] = {id: 2}
const expected = items.slice(start, end)
const base = {items}
const result = produce(base, draft => {
const sliced = draft.items.slice(start, end)
expect(Object.keys(sliced)).toEqual(Object.keys(expected))
expect(sliced.map(item => item.id)).toStrictEqual(
expected.map(item => item.id)
)
sliced[index].id = 20
})
expect(result.items[2].id).toBe(20)
expect(items[2].id).toBe(2)
expect(Object.keys(result.items)).toEqual(["2"])
}
)

test("distinguishes sparse slots from explicit undefined values", () => {
const items = new Array(3)
items[1] = undefined
const base = {items}
const result = produce(base, draft => {
const sliced = draft.items.slice()
expect(sliced).toStrictEqual(items)
expect(Object.keys(sliced)).toEqual(["1"])
})
expect(result).toBe(base)
})

test("returns sliced array", () => {
const base = createTestData()
const result = produce(base, draft => {
Expand Down
6 changes: 5 additions & 1 deletion src/plugins/arrayMethods.ts
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,11 @@ export function enableArrayMethods() {

// Return drafts for items in the slice range
for (let i = start; i < end; i++) {
result.push(state.draft_[i])
if (i in source) {
result.push(state.draft_[i])
} else {
result.length++
}
}

return result
Expand Down
Loading