Repository navigation
ci: build, test and release the NuGet package with GitHub Actions - #445
Merged
Merged
Conversation
Whitespace only (git diff -w is empty).
… tagged releases.
…keep Valencian out of the .NET lib folders.
…tag's build to NuGet.org and attaches it.
…n WPF apps against it.
…et no culture folders.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Packaging: the NuGet package is now produced by
msbuild -t:Packfromsource/iNKORE.UI.WPF.Modern.nuspecinstead of by hand. The layout is the same as 0.10.2.1 (net452,net6.0-windows10.0.18362,net6.0-windows7.0), with two fixes:iNKORE.UI.WPF.dllandSystem.ValueTuple.dllare no longer duplicated inlib/net452.Versioning: the version comes from MSBuild.
VersionPrefixinDirectory.Build.propsis used for local and CI builds; releases pass-p:Versionfrom the tag. The iNKORE.UI.WPF version is set once, inDirectory.Build.targets.build.yml: runs on PRs (after approval on thepr-buildenvironment), onv*tags and by hand. It builds the solution, packs, zips the Gallery and runstests/Package:net8.0-windows,net8.0-windows10.0.19041.0andnet48, built with bothdotnet buildand MSBuild, then run. They check the zh-TW strings, and that the output has no culture folders.The nupkg and
iNKORE.UI.WPF.Modern.Gallery@<version>.zipare uploaded unwrapped (archive: false), so each artifact downloads as the file itself.release.yml: publishing a GitHub release for av*tag, after approval on thenugetenvironment, pushes that tag build's nupkg to NuGet.org (Trusted Publishing) and attaches the nupkg and Gallery zip to the release.Actions: every action is pinned to a commit SHA, with its version in a comment. Dependabot (
.github/dependabot.yml) keeps them up to date in one grouped PR a week.Resources: renamed the
gd-gb/ca-Es-VALENCIAresx files to their standard culture casing,gd-GBandca-ES-valencia.Releasing
vX.Y.Z; Build runs automatically.nugetdeployment.Notes
build.ymlhas passed on this PR.release.ymlonly runs when a release is published, so the first release will be its first run.net*-windowsresolvelib/net6.0-windows7.0, where the system accent and theme don't work, because the DLL needsMicrosoft.Windows.SDK.NET.licenseUrl) during pack is expected.Tested locally:
dotnet buildand MSBuild: the zh-TW strings load from the embedded resources, and no culture folders appear in the output;