Repository navigation
⚡ Optimize makeMonthlyRegister O(N) collection scan in WebAPI - #523
Conversation
Co-authored-by: hrj <345879+hrj@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced the$O(N)$ filter scan per month and account inside
WebAPI.makeMonthlyRegisterwith pre-grouped posts by month (postsByMonth) and sequential running balance accumulation per account (runningBalances). Additionally usedgroupedPostsingetDetailsByMonthto avoid repeated full-sequence filtering.🎯 Why: Previously, for every month and account,$O(N \cdot M \cdot A)$ time complexity. Pre-grouping posts and maintaining running balances reduces the complexity to $O(N + M \cdot A)$ .
currPostswas filtered repeatedly to calculate prior post totals and month posts, leading to📊 Measured Improvement: Measured with
WebAPIBenchmarkTest:WebAPI.makeReportcall on a 2-year / 50-account dataset.makeReportexecution time (~2.76x speedup).PR created automatically by Jules for task 4032760993074246349 started by @hrj