Repository navigation
Add a HasLink instance for ServerSentEvents' - #1926
Merged
Merged
Conversation
Contributor
|
Looks good to me, assuming that CI passes |
Author
|
Thanks, @LaurentRDC. CI is green on every GHC version. Could you merge this when you have a moment? |
Contributor
|
Thanks for the ping! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerSentEvents'(added with client support in #1811) has noHasLinkinstance, sosafeLink,allLinksandfieldLinkfail to type-check on any API that contains an SSE endpoint. This adds the same terminal instance thatVerb,StreamandUVerbhave.Test plan
cabal test servant: 53 examples, 0 failures, including the new "generates correct links for ServerSentEvents" case.LinksSpecfails to compile at the new case.