Repository navigation
Show the location once it is found; build against miso 1.14.0 - #1
Merged
Merged
Conversation
`.location-data` was `display: none` and nothing ever showed it, so the coordinates were filled in but stayed hidden. Render the panel only once there is a location, and drop the `display: none`. The 1.10.0 bump failed to build, so nothing has deployed since. Move to miso 1.14.0 (cabal.project and flake.lock) and update `Main.hs`: `startApp defaultEvents`, `Href url False`, `Effect context props`, and `View () ()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://geolocation.haskell-miso.org showing nothing after "Get My Location".
Bug:
.location-datainassets/style.csswasdisplay: none, and nothing ever showed it. The coordinates were filled into the page but stayed hidden. The panel is now rendered only once there is a location, and thedisplay: noneis gone.Deploy: the miso 1.10.0 bump (cb1fe8f) failed to build, so the site is still the Sep 2025 build. This moves to miso 1.14.0 in
cabal.projectandflake.lock, and updatesMain.hsfor the new API:startApp defaultEvents appHref "assets/style.css" FalseEffect context props Model ActionView () () Model ActionNot built locally; CI on this PR is the first build.