[SinghTejveer]

Checklist

• I've read the publishing documentation.
• I've added the HACS action to my repository.
• (For integrations only) I've added the hassfest action to my repository.
• The actions are passing without any disabled checks in my repository.
• I've added a link to the action run on my repository below in the links section.
• I've created a new release of the repository after the validation actions were run successfully.

Links

Link to current release: https://github.com/SinghTejveer/send-to-car/releases/tag/v0.2.4
Link to successful HACS action (without the ignore key): https://github.com/SinghTejveer/send-to-car/actions/runs/39332778055/job/118334792869
Link to successful hassfest action (if integration): https://github.com/SinghTejveer/send-to-car/actions/runs/39332778055/job/118334792581

[hacs-bot]

Thank you for submitting your repository to HACS (Home Assistant Community Store).

Your submission is in the review queue:
Your repository is waiting to be reviewed and included in HACS.

You can view the current queue here. Pull requests are processed in the order they were created, oldest first.

What to avoid during review:
To help reviewers work efficiently, don't do the following:

• Comment on the pull request - The reviewer will contact you when they have feedback or questions.
• Open a new pull request - This won't speed up the process and creates duplicate work.
• Ask followers to comment on the pull request - This won't speed up the process and may delay your review.
• Merge in the default branch - Only do this if a maintainer asks you to resolve a merge conflict.

If you need to make changes:
You can continue updating your repository while waiting for review. Changes to your repository will be reflected when the reviewer examines it. Only comment on the pull request if you need to withdraw your submission or have critical information for reviewers.

About draft pull requests:
Draft pull requests aren't included in the review queue. Your pull request may be marked as draft by a reviewer if issues need to be addressed. Once you've resolved all issues, mark it as ready for review to re-enter the queue.

What happens next:
Once a reviewer examines your submission, they'll either:

• Approve and merge your pull request if everything meets the requirements
• Request changes or ask questions if adjustments are needed

[frenck]

Hi @SinghTejveer, thanks for the submission! 👋

The diagnostics output still leaks locations. custom_components/send_to_car/diagnostics.py (line 13) redacts lat, lon, latitude, longitude and address, but not name, and the favourites and recent places it dumps (lines 21-22) keep their name. That field often is the location: a place sent with only coordinates is named "{lat:.5f}, {lon:.5f}" (finder.py line 145), and an unnamed Photon result is named after its house number and street (providers.py line 167). Anyone sharing a diagnostics file would hand out where they have been and where they live. Please add "name" to REDACT.

Once that's addressed, push a new release and re-request review.

../Frenck

                       

Blogging my personal ramblings at frenck.dev
Or subscribe to my free bi-weekly newsletter: frenck.dev/newsletter

[SinghTejveer]

Thanks @frenck! name and place_id are now redacted in diagnostics, with a test that checks nothing location-related (or the Google key) gets through. Fixed in v0.2.6: https://github.com/SinghTejveer/send-to-car/releases/tag/v0.2.6