Repository navigation
Declare the dev extra the Readme installs; test pull requests in CI - #136
Merged
Merged
Conversation
The Readme told contributors to `pip install -e .[dev]` but no such extra existed, and moto (needed by tests/test_s3.py) was declared nowhere, so the S3 streaming path was skipped both locally and in CI. The extra now lists the test tooling and CI installs it. CI also runs on pull_request so contributions from forks are tested, as the Readme already claimed. requires-python is declared so pip refuses unsupported interpreters, the coverage artefacts are ignored, and the mention of a pre-commit setup that does not exist is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Readme told contributors to
pip install -e .[dev]but no such extra existed, and moto (needed by tests/test_s3.py) was declared nowhere, so the S3 streaming path was skipped both locally and in CI. The extra now lists the test tooling and CI installs it. CI also runs on pull_request so contributions from forks are tested, as the Readme already claimed. requires-python is declared so pip refuses unsupported interpreters, the coverage artefacts are ignored, and the mention of a pre-commit setup that does not exist is dropped.