Repository navigation
Name loose S3 objects relative to their common prefix - #133
Merged
Merged
Conversation
Remote objects were named by basename only, so pdfs/a/x.pdf and pdfs/b/x.pdf listed under pdfs/ both mapped to x.grobid.tei.xml: within a chunk the second overwrote the first, across chunks it was skipped as already done. Objects are now named by their key relative to the common prefix of the listing, mirroring what local directories and archives do, and the citation-list download route keeps that relative path on disk.
lfoppiano
force-pushed
the
fix/s3-output-names
branch
from
November 8, 2026 08:52
659daad to
59601fd
Compare
lfoppiano
force-pushed
the
fix/citation-list-inputs
branch
from
November 8, 2026 08:52
bb95ff0 to
077d5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote objects were named by basename only, so pdfs/a/x.pdf and pdfs/b/x.pdf listed under pdfs/ both mapped to x.grobid.tei.xml: within a chunk the second overwrote the first, across chunks it was skipped as already done. Objects are now named by their key relative to the common prefix of the listing, mirroring what local directories and archives do, and the citation-list download route keeps that relative path on disk.