Repository navigation
feat: show the existing window when Gitify is launched again - #3646
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Make launching an already-running Gitify show its existing window, rather than silently exiting the second process. This is a usability improvement, not a restoration of ordinary-relaunch behavior lost in 8.0.0, and it does not need to block the hotfix.
Background
Gitify previously registered a
second-instancelistener to forwardgitify://OAuth callback URLs to the running instance. That listener did not show the window for an ordinary launch without a callback URL.The device-flow migration in #3449 removed the obsolete callback listener. Single-instance enforcement remains in place: a second process still quits. macOS activation is also still handled by electron-menubar.
This PR adds explicit show-on-relaunch behavior, particularly for Windows/Linux, addressing #3556.
Changes
second-instanceby showing the existing menubar window rather than toggling it.activatehandling with electron-menubar; do not restore obsolete OAuth protocol handling.Fixes #3556.
Verification
pnpm checkpassed.pnpm testpassed: 219 files, 2,191 tests.pnpm buildpassed.whenReady.