Repository navigation
test: replace login and repository-header snapshots with behaviour - #3514
Merged
Merged
Conversation
Assert login forms, forge choice, and repository-header actions through roles and labels instead of full markup snapshots. Associate the login form labels with their inputs and give the repository button a clear accessible name. Delete the seven obsolete snapshot files.
|
Contributor
|
🎉 This pull request is included in Gitify v8.0.0! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Gitify better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RepositoryHeadersnapshots with assertions for the repository name, actions, collapse toggle, all-read state, and default avatar..snapfiles.Accessibility fixes surfaced by the rewrite
FormControl id.aria-label(Open repository <repo>), instead of an inferred name built from the avatar and count.Verification
pnpm test: 200 files, 1,968 tests passedscripts/visual.sh: 60 tests passedpnpm exec vp check --no-fmt: 466 files passedCloses #3509. Advances #3510.