Skip to content

Clarify that DO_NOT_TRACK only disables telemetry for 1 or true - #46297

Closed
kburym wants to merge 1 commit into
github:mainfrom
kburym:docs/do-not-track-values
Closed

kburym wants to merge 1 commit into
github:mainfrom
kburym:docs/do-not-track-values

Conversation

@kburym

@kburym kburym commented Oct 13, 2026

Copy link
Copy Markdown

Fixes #45957

The GitHub CLI telemetry page implied any truthy value works for DO_NOT_TRACK. In internal/telemetry/telemetry.go (cli/cli at 0cf1092), DO_NOT_TRACK disables telemetry only when its trimmed, lowercased value is 1 or true. This adds that sentence next to the example.

@github-actions

Copy link
Copy Markdown
Contributor

Please don't raise pull requests against an existing issue that another user has raised until it's been marked with a help wanted label. We need to properly assess all issues before we can accept community contributions, and determine whether it's something we need to fix internally, or how many articles are affected and what the scope of the fix will be. For now, we're going to close this pull request.

@github-actions github-actions Bot closed this Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR to the GitHub Docs project!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
github-cli/github-cli/github-cli-telemetry.md fpt
ghec
ghes@ 3.22 3.21 3.20 3.19 3.18
fpt
ghec
ghes@ 3.22 3.21 3.20 3.19 3.18

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify that DO_NOT_TRACK only disables telemetry if 1 or true

1 participant