Repository navigation
fix(fluentbit): render a shared ClusterMultilineParser only once - #2105
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListFluentBitConfigResourcesrenames each cluster-level copy to<name>-<md5(namespace)>, so two FluentBitConfigs in one namespace that both select the same ClusterMultilineParser giveRenderMultilineParserConfigtwo lists holding the identical name. Both are written, and Fluent Bit gets two[MULTILINE_PARSER]sections sharing a Name.RenderParserConfigright above it already carries anexistingParsersset for exactly this case. The multiline path never got one.I added a test for the multiline path and one for the parser path as a control. Before the change the multiline case writes the section twice and the parser case once.
go test -race ./apis/...passes.