Repository navigation
Fix :in-range and :out-of-range on inputs without a type - #326
Merged
Merged
Conversation
Owner
|
@gir-bot lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:in-rangeand:out-of-rangeraise aTypeErroras soon as the document contains aninputwithout atypeattribute:It happens with
html.parser,lxmlandhtml5lib, and on 2.7 and 3.0.0 through 3.0.4 as well asmain.In
_match_selectorsthe range check runs right after the attribute check, but the[type=...]filter of the:in-range/:out-of-rangepattern lives in an:is(...)sub-selector, which is evaluated later. Somatch_range()is called for everyinput, andutil.lower(self.get_attribute_by_name(el, 'type'))getsNonewhen there is notypeattribute.This passes
''as the default, as other attribute lookups do. An untyped input is a text input, soInputs.parse_value()returnsNonefor its bounds andmatch_range()returnsFalsebefore the:is([type=...])filter would reject it anyway. Chrome agrees on the new test markup::in-rangematches only#1and:out-of-rangeonly#2.Tests:
test_in_range_untyped_inputandtest_out_of_range_untyped_inputfail onmainwith theTypeErrorand pass with the change.pytest tests(428 passed),ruff check .andmypypass. I added a changelog entry under "Unreleased".