Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…e outside it Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…torage # Conflicts: # src/static/lang/en.json # src/static/lang/fi.json # src/static/lang/fr.json # src/static/lang/nb.json # src/static/lang/sv.json
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs entur/tiamat#505 merged and deployed first. The editor sends the cycle storage equipment
id, which only #505 accepts.Summary
The modern editor shows and edits the cycle storage of every parking.
racks,barsandrailings.cycleSchemeorothervalue shows as its label. A save keeps it.placeEquipmentsonly after a cycle storage edit. It then sends every equipment kind with itsid.fi,sv,nbandfrtranslations. Native speakers should check them.Type of change
Issue
Tiamat exposes cycle storage on a parking since #465. No editor showed it.
Unit tests
See Verification.
Verification
parkingCycleStorage.spec.js(18)Cannot read properties of undefined (reading 'cycleStorageEquipment'). The unchanged-save guard and the type-list test passCycleStorageFields.spec.tsx(8)expected [] to have a length of 2 but got +0expected [ Array(4) ] to deeply equal [ 'Racks', 'Bars', 'Railings' ]placeEquipmentsexpected {...} to not have property "placeEquipments"npx vitest runnpx tsc --noEmitandnpm run checkBars, empty spaces. An unchanged save sends noplaceEquipmentsrackswith 10 spacescycleStorageEquipmentlistrackswith 6 spacescycleSchemeCycle schemeshows. The menu listsRacks,BarsandRailings. A save keepscycleSchemeshelterEquipmentrackswith 12 spacesEach screenshot shows the base on the left and this PR on the right.
Known limitations
NumberOfSpaces. The editor accepts an entry without it, because migrated data has none.cycleSchemeorother.