Repository navigation
docs: overview of the clients registered for LS AAI - #32
Conversation
Reviewer's GuideImplementationSwitch entitlement scope, mock claims, and UserInfo processing to the
Enable interactive readline history for the session command line.
ConfigurationUpdate the repository ignore configuration.
DocumentationDocument the registered LS AAI clients and align entitlement scopes and claims across the registration, assumptions, and group-test guidance.
Explain that login tests use a temporary callback port so an existing LS Login session can remain running.
TestsUse a temporary callback port in login tests and update fixtures and assertions to expect the
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Documentation build overview
6 files changed ·
|
Linked issuesChecked at commit 71e4e90 #9 chore: find out how to assign test groups · 2 of 3 met · 1 to check by hand
|
There was a problem hiding this comment.
Hey - I've found 3 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/setup/client-registration.md" line_range="53" />
<code_context>
+| Gateway | `ELIXIR On-Cloud token exchange testbed gateway` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4304 |
+| Orchestrator | `ELIXIR On-Cloud token exchange testbed orchestrator` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4308 |
+| Client | `ELIXIR On-Cloud token exchange testbed client` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4309 |
+| Public client (optional) | `ELIXIR On-Cloud token exchange testbed client` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4309 |
+
## Group release
</code_context>
<issue_to_address>
**Public client uses wrong facility**
When an operator follows the table to locate or configure the separately registered public client, the public-client row points to facility 4309, already listed for `tx-test-client`, and repeats its service name, so operators cannot identify the separate `tx-test-public` registration or configure its groups and distinct client credentials on the intended facility; public-client tests then use the wrong registration.
Replace the public-client row's service name and URL with those of the distinct `tx-test-public` facility.
</issue_to_address>
### Comment 2
<location path="docs/setup/client-registration.md" line_range="53" />
<code_context>
+| Gateway | `ELIXIR On-Cloud token exchange testbed gateway` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4304 |
+| Orchestrator | `ELIXIR On-Cloud token exchange testbed orchestrator` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4308 |
+| Client | `ELIXIR On-Cloud token exchange testbed client` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4309 |
+| Public client (optional) | `ELIXIR On-Cloud token exchange testbed client` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4309 |
+
## Group release
</code_context>
<issue_to_address>
**Public-client tests are skipped**
When a reader follows the registered-services table literally, a reader can omit `tx-test-public`, leaving the documented five-client setup incomplete and preventing the public-client exchange variant from being run.
Remove “optional,” or clarify that the public client is optional only when deliberately skipping the public-client test.
</issue_to_address>
### Comment 3
<location path="docs/setup/client-registration.md" line_range="49-53" />
<code_context>
+
+| Role | Service name | Registration link |
+|---|---|---|
+| Node | `ELIXIR On-Cloud token exchange testbed node` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4303 |
+| Gateway | `ELIXIR On-Cloud token exchange testbed gateway` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4304 |
+| Orchestrator | `ELIXIR On-Cloud token exchange testbed orchestrator` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4308 |
+| Client | `ELIXIR On-Cloud token exchange testbed client` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4309 |
+| Public client (optional) | `ELIXIR On-Cloud token exchange testbed client` | https://services.aai.lifescience-ri.eu/spreg/auth/facilities/detail/4309 |
+
## Group release
</code_context>
<issue_to_address>
**Registration URLs are not clickable**
When a reader views the rendered documentation, mkDocs renders the bare registration URLs as text, so readers cannot open the facility pages directly from the documentation.
Format each registration URL as a Markdown link.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: docs/setup/client-registration.md:53, docs/setup/client-registration.md:53
uniqueg
left a comment
There was a problem hiding this comment.
Thanks! Can you please address or reject the open Sourcery comments? 🙏 Otherwise looks good :)
6499264 to
71e4e90
Compare
71e4e90 to
1a35ae0
Compare
|
I made a few more improvements; see the PR description. |
Summary
I completed the client registration for the LS AAI and added the relevant documentation.
Changed the use of the
eduperson_entitlementscope and claim toentitlements,aseduperson_entitlementis considered legacy according to the AARC-G069 guideline. and is kept for backward compatibility.Tests use a temporary port automatically to prevent conflicts with running Docker.
Initial login through LS AAI works.
Closes #8
Verification
Go through the registered clients in the LS AAI client registration app. All members of
ECP_CLN:ADMINgroup should be able to see them.Configure
lslogin.envand test initial login.Declined review findings
Open questions
Checklist
pass.
Commits (at most 50 characters,
imperative mood, no trailing period).
Summary by Sourcery
Align LS AAI client registration and entitlement processing with the current
entitlementsstandard while documenting registered services and improving login test isolation.Enhancements:
entitlementsscope and claim across the testbed and its documentation.Documentation:
Tests:
entitlementsand isolated callback ports.Chores: