Repository navigation
docs: resource and group assigning to the client within LS AAI - #30
Merged
Merged
Conversation
Reviewer's GuideDocumentationUpdate the LS AAI resource and group-assignment workflow across the client-registration and T3 documentation, including who assigns groups, how to verify released entitlements, and the testbed’s intentional orchestrator omission.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Documentation build overview
|
Linked issuesChecked at commit e9bc6fd #9 chore: find out how to assign test groups · 2 of 3 met · 1 to check by hand
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/setup/client-registration.md" line_range="63-68" />
<code_context>
+The VO admins perform group assignments to the resource. The client maintainer creates the resources, then sends the VO admins links to the resource and to groups he wants to assign to the resource.
</code_context>
<issue_to_address>
**Group assignment instructions conflict**
When the maintainer follows the setup checklist in order, the maintainer following the earlier “For the test” checklist is told to assign the group themselves, then this section says VO admins perform that assignment. They may try the unavailable assignment themselves instead of handing it off, delaying resource setup.
Update the earlier checklist to say the maintainer creates each resource and the VO admins assign the group.
</issue_to_address>
### Comment 2
<location path="docs/setup/client-registration.md" line_range="63" />
<code_context>
+
+Being able to open a facility and create a resource does not establish permission to assign a VO's groups. A greyed-out Next button under "Assign groups" may indicate missing permissions.
+
+The VO admins perform group assignments to the resource. The client maintainer creates the resources, then sends the VO admins links to the resource and to groups he wants to assign to the resource.
+
+### Assigning groups and verifying release
</code_context>
<issue_to_address>
**Required Perun role remains unknown**
When an operator needs to request the permission to assign groups rather than delegate the work to VO admins, operators who need to identify which Perun permission to request still get no answer: the new instructions identify VO admins as the people to delegate to, while T3 continues to mark the required role as unresolved. They cannot determine which role enables group assignment.
Name the verified Perun role, or explicitly state that it is still unknown and that operators should delegate assignments to VO admins.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: docs/setup/client-registration.md:68, docs/setup/client-registration.md:63
xpavlic
force-pushed
the
xpavlic/client_registration
branch
from
November 11, 2026 09:13
4cdb566 to
dcbdacb
Compare
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation for resources and groups assigning to clients.
Closes #9
Verification
Process verified with Elixir VO admins.
Checklist
pass.
Commits (at most 50 characters,
imperative mood, no trailing period).
Summary by Sourcery
Document the resource and group assignment workflow for client setup in LS AAI, including delegated VO-admin responsibilities and entitlement verification.
Enhancements:
Documentation: