Repository navigation
ci: fail the scheduled image scan again - #159
Conversation
Drop fail: "false" from scan.yml now that 0.12.0 published latest through the release workflow and its scan has no critical or high findings. Update the header comment and the note in development.md. Closes #158 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewer's GuideConfigurationRe-enable failure on fixed critical and high vulnerabilities in the scheduled image scan, and update the workflow comment to describe the behavior.
DocumentationUpdate the development guide to describe the scan's failure criteria and remove the obsolete instruction to re-enable failure.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #159 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1799 1799
=========================================
Hits 1799 1799 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Linked issuesChecked at commit ee5b465 #158 ci: fail the scheduled image scan again · 2 of 3 met · 1 to check by hand
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/scan.yml" line_range="54" />
<code_context>
image: docker.io/${{ vars.DOCKERHUB_ORG || 'elixircloud' }}/tesk-core-${{ matrix.image }}:latest
category: release-image-${{ matrix.image }}
report: "true"
- fail: "false"
</code_context>
<issue_to_address>
**Scheduled scan fails on stale image**
When a scheduled or manually dispatched scan overlaps a release retag, and the old image has a fixable critical or high finding cleared by that release, a matrix job can pull the old `:latest` digest just before the release retags it, then fail on a fixable critical or high finding even though the release has scanned the new digest and is publishing it. The scheduled run reports a failure for a vulnerability no longer present in the released image.
Retry or defer enforcement when `latest` changes during a scan, so the job evaluates the currently published digest.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .github/workflows/scan.yml:54
| image: docker.io/${{ vars.DOCKERHUB_ORG || 'elixircloud' }}/tesk-core-${{ matrix.image }}:latest | ||
| category: release-image-${{ matrix.image }} | ||
| report: "true" | ||
| fail: "false" |
There was a problem hiding this comment.
🟡 Medium · Scheduled scan fails on stale image
When a scheduled or manually dispatched scan overlaps a release retag, and the old image has a fixable critical or high finding cleared by that release, a matrix job can pull the old :latest digest just before the release retags it, then fail on a fixable critical or high finding even though the release has scanned the new digest and is publishing it. The scheduled run reports a failure for a vulnerability no longer present in the released image.
Retry or defer enforcement when latest changes during a scan, so the job evaluates the currently published digest.
Prompt for AI agents
In `.github/workflows/scan.yml` at line 54:
**Scheduled scan fails on stale image**
When a scheduled or manually dispatched scan overlaps a release retag, and the old image has a fixable critical or high finding cleared by that release, a matrix job can pull the old `:latest` digest just before the release retags it, then fail on a fixable critical or high finding even though the release has scanned the new digest and is publishing it. The scheduled run reports a failure for a vulnerability no longer present in the released image.
Retry or defer enforcement when `latest` changes during a scan, so the job evaluates the currently published digest.
Summary
The scheduled scan of the released images (
Scan,.github/workflows/scan.yml) fails again on critical and high vulnerabilities that have a fix, as CI,release.ymland tesk-api do:fail: "false"from the scan step and update the workflow's header comment.docs/development.mdand remove the to-do to dropfail: "false".0.12.0 republished
latestthrough the release workflow on 2026-11-15. The scheduled run on 2026-11-16 (43811167413) left one medium alert per image inrelease-image-filerandrelease-image-taskmaster, and no critical or high alerts, so the scan passes with this change.Closes #158
Verification
release-image-filerandrelease-image-taskmaster, no critical or high.Lint); it couldn't run locally (no actionlint version is set in mise).Light lane
This PR changes only CI configuration and docs. It touches no secrets, permissions or the release workflow, so I reviewed the diff myself.
🤖 Generated with Claude Code
Summary by Sourcery
Enforce failure reporting for fixable critical and high vulnerabilities in scheduled released-image scans.
Bug Fixes:
CI:
Documentation: