Repository navigation
Conversation
Lists ELIXIR grants under one ELIXIR programme (data category and filter), titles each card with its programme and logo (ELIXIR, Google Summer of Code), shows the detailed grant type as a subtitle, drops the Grant/GSoC badges, sorts grants by end date, start date and name, and puts the ELIXIR grants stat before the GSoC one, in sentence case. Adds the Google Summer of Code mark (from the GSoC site's logo) as public/gsoc.svg. Refs #214 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #214 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keeps the programmes and their logos in PROGRAMMES (src/lib/funding.ts), which sets the order of the filters, so that the order no longer depends on which grant ends last. Tests check that every programme has its logo and that every grant has the fields the card shows. Refs #214 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Asserts the stat values and the literal filter order, checks that every programme has grants, and documents that a grant type starts with its programme's name. Refs #214 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideData structuresUpdate the five ELIXIR grants to use the ELIXIR programme category and correct the commissioned-service funder wording.
APIDefine the grant and programme types, programme names and logos, plus the shared sorting and grant-type helpers used by the Funding page.
UIRender programme-based funding filters and statistics, and show sorted grant cards with programme logos, titles and optional detailed-type subtitles.
Add the Google Summer of Code logo used on programme grant cards.
DocumentationDocument funding fields, display and sort rules, and the steps for adding a programme.
TestsTest Funding page statistics, filter order, card content and sorting, and update filter tests for programme-based filtering.
Validate funding data against configured programmes and test the grant sorting, type and unknown-programme checks.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #223 +/- ##
==========================================
+ Coverage 49.86% 50.44% +0.58%
==========================================
Files 44 45 +1
Lines 1105 1118 +13
Branches 292 294 +2
==========================================
+ Hits 551 564 +13
Misses 479 479
Partials 75 75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Linked issuesChecked at commit 000c3ec #214 feat: revise the Funding page · 7 of 7 met
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/lib/funding.ts" line_range="16" />
<code_context>
- endDate: string;
- formattedDuration: string;
- category: string;
-};
-
-const grants = fundingData as FundingItem[];
</code_context>
<issue_to_address>
**Mistyped programmes remain unfilterable**
When a funding record has a category not listed in `PROGRAMMES` and reaches the page, the string type and `as Grant[]` assertion do not constrain a record's category to `PROGRAMMES`. The page builds filters and logo lookups only from that registry, so a record with another category appears without a logo and cannot be selected by a filter.
Constrain categories to the programme names and validate the imported data against that model.
Also at `src/lib/funding.ts:48`.
</issue_to_address>
### Comment 2
<location path="src/app/funding/page.tsx" line_range="63" />
<code_context>
+ // The stats name the two programmes, as the issue for the page asks;
+ // a new programme gets a filter (PROGRAMMES) but no stat of its own
+ const gsocCount = grants.filter(
+ (g) => g.category === 'Google Summer of Code',
).length;
- const elixirCount = grants.filter((g) => g.funder.includes('ELIXIR')).length;
</code_context>
<issue_to_address>
**Programme stats drift from configured names**
When an existing programme's name changes in `PROGRAMMES` and `funding.json`, `gsocCount` and `elixirCount` keep comparing against literal category names, so if a programme is renamed in `PROGRAMMES` and the grant data follows, its stat reports zero even though grants are listed under that programme.
Derive the stat count predicates from shared programme-name constants or `PROGRAMMES` entries instead of repeating the category strings.
Also at `src/app/funding/page.tsx:65`.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: src/lib/funding.ts:16, src/app/funding/page.tsx:63
Types a grant's category as one of the programmes and checks the data on load, so that a grant of an unknown programme fails the build instead of showing without a logo or filter. The stats use the shared programme names. Addresses Sourcery's review. Refs #214 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #214
Summary
Revises the Funding page as the review of 2026-11-18 asks (#209).
PROGRAMMES(src/lib/funding.ts), which also holds each programme's logo.sortGrantsinsrc/lib/funding.ts.public/elixir.png; the GSoC mark aspublic/gsoc.svg, taken unchanged from the logo on summerofcode.withgoogle.com) and only "ELIXIR" or "Google Summer of Code" as its title. The "Grant" and "GSoC" badges are gone. ELIXIR grants show their detailed type as a subtitle, e.g. "ELIXIR Commissioned Service: Technology" or "ELIXIR Strategic Implementation Study"; GSoC grants show none.Data changes (for @keshxvdayal, #216)
Kept to what this issue needs, so that they don't get in the way of the data check in #216:
categoryof the five ELIXIR grants is nowELIXIR(it is the card title and the filter).funder"ELIXIR Commissioned Services: Technology" is now "ELIXIR Commissioned Service: Technology", the singular as in the issue, like the other grant types.Nothing else in
src/data/funding.jsonchanged. No shared component changed.Old filter links
The filter ids
elixir-services,elixir-platform-tasksandelixir-implementation-studiesno longer exist; links with them open the page unfiltered (unknown ids are ignored, as for every listing). Nothing on the site links them, and the filters are only a few days old.Verification
npx vitest run: 300 passed (new:src/app/funding/page.test.tsxfor stats, filters, sort order and card titles, logos and subtitles;src/lib/funding.test.tsfor the sort and the grant type; data tests forfunding.json; the Funding filter tests updated to the one ELIXIR filter).npm run lint,npx tsc --noEmit,npx prettier --check: pass.npm run build: passes;/fundingis static.next start) in headless Chromium, light and dark: stats order, the two filters, the sort order, logos on white tiles in both themes, subtitles only on ELIXIR cards. Screenshots could not be attached from the command line; please check the Vercel preview.Declined review findings
role="article"on the grant cards (Cardrenders adiv): kept. It gives the cards the same role as the<article>cards of the Products and Demo listings, which the tests of those pages also use.src/lib/filters.test.tsand the Products and Contributors filter tests.formattedDurationmatches the dates: out of scope here; the README says to keep them in step, and fix: check funding and contributor data by hand #216 checks the data by hand.🤖 Generated with Claude Code