Repository navigation
docs: document LS Login groups and facilities - #180
Merged
Merged
Conversation
Add a section "Groups and facilities" to the LS Login operator page: how LS Login releases groups per client facility, which client needs them, the second resource for users outside the groups, how to assign groups, the form of the entitlement values and how to read them, how the services read them, and a checklist for 403s. Also add the test environment's 30-day rule and links to the terms and the service level declaration. Closes #176 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Reviewer's GuideDocumentationDocument LS Login service registration, group release and facility assignment, entitlement handling, and troubleshooting so operators can configure access and diagnose 403 responses.
Update the operator index description to reflect the new LS Login guidance.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Update the LS Login row of the operator index for the new section "Groups and facilities". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Documentation build overview
|
uniqueg
marked this pull request as ready for review
November 18, 2026 05:12
Contributor
Linked issuesChecked at commit f98a8e9 #176 docs: document LS Login groups and facilities · 8 of 8 met
|
Contributor
There was a problem hiding this comment.
Hey - I've found 4 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/operators/ls-login.md" line_range="175" />
<code_context>
+
+1. **Membership:** is the user a member of the group in Perun?
+2. **Release:** is the group assigned to a resource on the facility of the
+ client that the user logged in with (the token's `aud`), not of another
+ client?
+3. **Scope:** did the client request `eduperson_entitlement`, and does the
</code_context>
<issue_to_address>
**403 checks use wrong facility**
When a request uses an exchanged token and the exchanging client differs from the original login client, the checklist directs operators to use the interactive-login client’s facility, identified by the token’s `aud`, although the preceding guidance says entitlements are computed for the client calling the exchange. Operators check the wrong Perun facility and the 403 remains unresolved.
For exchanged tokens, direct operators to check the facility of the client calling the exchange rather than the interactive-login client identified by `aud`.
</issue_to_address>
### Comment 2
<location path="docs/operators/ls-login.md" line_range="34-36" />
<code_context>
+### Test and production
+
+LS Login keeps a new service in its test environment for at most 30 days.
+If its owner takes no action within another 14 days, LS Login deactivates
+the service (the LS Login team, December 2025). Move a service to
+production in time, as described in the [LS Login
+docs](https://lifescience-ri.eu/registering-integrating-and-managing-your-service/).
</code_context>
<issue_to_address>
**Match the 30-day rule**
The issue asks operators to be told that test-environment clients are deactivated after 30 days without action. This text instead describes a 30-day test period followed by another 14 days without action before deactivation.
</issue_to_address>
### Comment 3
<location path="docs/operators/ls-login.md" line_range="167" />
<code_context>
+ `security.access_control.group_mapping` (see [Cloud
+ Registry](cloud-registry.md#identity-provider)).
+- TESK reads one claim of the user info and accepts the listed values (see
+ [Onboard a Node](node-onboarding-tutorial.md#tesk)).
+
+### Checklist for a 403
</code_context>
<issue_to_address>
**TESK support looks confirmed**
When operators use TESK with LS Login and rely on the new description as confirmation that the integration works, when operators rely on this bullet to configure TESK with LS Login, it presents reading and accepting the groups as established behavior. The linked onboarding guide says LS Login token acceptance and TESK’s group model have not been verified, so operators are given more assurance than the documented integration supports.
Qualify the TESK bullet with the existing verification caveat, or document verified support before presenting it as established.
</issue_to_address>
### Comment 4
<location path="docs/operators/ls-login.md" line_range="150-151" />
<code_context>
+
+```bash
+read -rs TOKEN
+printf 'Authorization: Bearer %s\n' "$TOKEN" | curl -fsS -H @- \
+ https://login.aai.lifescience-ri.eu/oidc/userinfo
+```
+
</code_context>
<issue_to_address>
**User-info check hangs**
When the user-info endpoint accepts a connection but stops responding, or the network blackholes the request, `curl` has no connection or overall time limit, so a stalled LS Login endpoint or network leaves the operator's 403 diagnostic blocked instead of returning a bounded failure.
Add a suitable `--connect-timeout` and `--max-time` to the `curl` command.
</issue_to_address>Sourcery assessment
Approval pending. 4 findings to address first.
Blocking findings: docs/operators/ls-login.md:175, docs/operators/ls-login.md:36, docs/operators/ls-login.md:167, docs/operators/ls-login.md:151
- Name the exchanging client's facility for exchanged tokens in the 403 checklist. - Say that TESK's acceptance of LS Login tokens is not verified yet. - Bound the user info curl call with connect and total timeouts. Addresses Sourcery review threads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a section "Groups and facilities" to the LS Login operator page (
docs/operators/ls-login.md), covering the six points of the issue:eduperson_entitlement, needs the scope of that name), not in the access token; how FOCA-based services and TESK read them.Also: the second resource for the Lifescience VO members group, so that users outside the mapped groups can log in and get a 403 from the service, and who can assign groups (TrustedFacilityAdmin within the VO, otherwise the VO admins on request).
The LS Login row of the operator index (
docs/operators/index.md) now names the new section.Sources: Perun's public docs (Entitlements, Group entitlement, resource and role pages), the token-exchange testbed's "Group release" (assumptions A5, A9, A10, statements of the LS Login team), the LS Login discovery document, and the LS Login team's test-environment rule (WP2 minutes, December 2025). Generic: example VO and group names, no client IDs, no secrets, no personal data.
last_verifiedstaysnull.Light lane: docs only, one page, no code.
Verification
python scripts/check_names.py: passed.DOCS_REGISTRY_OFFLINE=1 mkdocs build --strict: passed (links and anchors between pages checked).pytest: 356 passed, 100% coverage.mainand the Sourcery fixes (c0d35e0): CI green (CI passed, Docs, Test, PR title, CodeQL), Read the Docs build succeeded, Sourcery check passed.Declined review findings
Open questions
None.
Closes #176
🤖 Generated with Claude Code
Summary by Sourcery
Document LS Login group release, facility configuration, entitlement handling, and authorization troubleshooting for service operators.
Enhancements:
Documentation: