[jor-mar]

[Dark mode] The Registers View does not display the icons properly in dark mode

Register view icons are currently not clearly visible in dark mode. In a previous fix (2020), dark mode changes register_view.png from #17315d to #127cba. Registers view icons (row and group) now change to #2e95d3 in dark mode.

Fixes #2308

[github-actions]

Test Results

    54 files  ±0      54 suites  ±0   35m 13s ⏱️ -18s
 4 982 tests ±0   4 960 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 837 runs  ±0  12 683 ✅ ±0  154 💤 ±0  0 ❌ ±0 

Results for commit fc3fa4f. ± Comparison against base commit e85e581.

♻️ This comment has been updated with latest results.

[vogella]

Thanks, I tested this in the Registers view and it clearly fixes the issue. Two things before merging:

Could you try a slightly lighter blue such as #2e95d3? With #127cba, contrast on a selected row in dark mode drops from 2.09 to 1.34, and it is 2.94 on normal rows. #2e95d3 should give about 1.85 and 4.05, and still about 3.30 on white. Please check how it looks in both themes.

Could you also reference #2308 in the commit message?

[vogella]

Would be great if you could do this update soon, as M3 is approaching and after M3 merging becomes more time-consuming.

[jor-mar]

Latest commit uses your suggested #2e95d3. Hope it helps!

[vogella]

Thanks for updating the commit message, but AFAICS the color itself did not change

[vogella]

Please squash commits into one

[jor-mar]

Apologies. Should be good to go now (hopefully).