Skip to content

Volume destroy crash recovery: test coverage and review follow-ups - #188

Merged
nnastonen merged 2 commits into
eBay:dev/v6.xfrom
nnastonen:SDSTOR-26085_volume_destroy_crash_recovery_followups
Oct 16, 2026
Merged

nnastonen merged 2 commits into
eBay:dev/v6.xfrom
nnastonen:SDSTOR-26085_volume_destroy_crash_recovery_followups

Conversation

@nnastonen

@nnastonen nnastonen commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Improvements in unit tests and made _PRERELEASE work in HomeBlocks.

@nnastonen
nnastonen force-pushed the SDSTOR-26085_volume_destroy_crash_recovery_followups branch from a76ce5b to 8a51b43 Compare October 15, 2026 14:26
@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev/v6.x@76bb1e0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/lib/volume/volume.cpp 0.00% 1 Missing ⚠️
src/lib/volume/volume_chunk_selector.cpp 66.66% 0 Missing and 1 partial ⚠️
src/lib/volume_mgr.cpp 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             dev/v6.x     #188   +/-   ##
===========================================
  Coverage            ?   50.55%           
===========================================
  Files               ?       19           
  Lines               ?     1357           
  Branches            ?      600           
===========================================
  Hits                ?      686           
  Misses              ?      273           
  Partials            ?      398           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nnastonen
nnastonen force-pushed the SDSTOR-26085_volume_destroy_crash_recovery_followups branch from 144574b to 5cdafed Compare October 15, 2026 15:09

@JacksonYao287 JacksonYao287 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nnastonen
nnastonen merged commit fbd1832 into eBay:dev/v6.x Oct 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants