Repository navigation
fix: resolve four single Eclipse warnings - #1621
Merged
Merged
Conversation
A trailing continuation on the source.. line made "output.. = bin/" part of its value, so Eclipse reported a source folder of that name as missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bundle contributes no extensions or extension points, which Eclipse reports as a warning on the empty manifest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
IJvmDeclaredTypeAcceptor.accept(T) is abstract and returns the deprecated IPostIndexingInitializing, so an implementation can't avoid naming it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joaodinissf
marked this pull request as ready for review
November 6, 2026 00:54
rubenporras
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes four unrelated single warnings Eclipse reports, as one commit each.
xtext.generator/build.properties: a trailing continuation on thesource..line madeoutput.. = bin/part of its value, so PDE reported a source folder of that name as missing.CheckGeneratorExtensions.formatDescription: theJavaDoc2HTMLTextReaderis now closed, using try-with-resources.com.avaloq.tools.ddk/plugin.xml: removed along with itsbuild.propertiesentry. The file was empty, which PDE warns about, and the bundle contributes no extensions or extension points.ExportJvmModelInferrerTest: a method-level@SuppressWarnings("deprecation")onRecordingAcceptor.accept(T).IJvmDeclaredTypeAcceptordeclares this method abstract with the deprecated return typeIPostIndexingInitializing, so an implementation can't avoid naming it.This also bumps
xtext.generator,check.coreandcom.avaloq.tools.ddk, as the version baseline check requires.Testing
clean verifywithcheckstyle:check,pmd:check,pmd:cpd-checkandspotbugs:checkpasses, including the version baseline check. 451 tests ran with no failures or errors, and 2 were skipped.🤖 Generated with Claude Code