Repository navigation
fix(examples): admit codex 0.166 in the codex acp adapter - #190
Merged
Merged
Conversation
codex-acp 2.5.0 still declares @openai/codex ^0.165.0, and no upstream release moves it, so the adapter kit refused the current codex kits. A full ACP session (initialize, session/new, session/prompt to end_turn) against a composed codex 0.166.0 behaves as it does on 0.165.0, so widen the requirement to < 0.167.0 and move codex-acp-set 1.0.7 onto codex-mixin 0.166.0. Signed-off-by: Christian Dupuis <cd@docker.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the Codex 0.166 compatibility update.
No open issues 🎉
What changed in this PR
Updates the Codex ACP example kits to compose with Codex 0.166 while retaining compatibility with 0.165.
Changes:
- Widens the adapter’s Codex requirement to
>= 0.165.0, < 0.167.0. - Updates the composed set to use
codex-mixin:0.166.0and bumps its version to1.0.7. - Extends compatibility tests to accept 0.166.x and reject 0.167.0.
| File | Description |
|---|---|
examples/codex-acp/codex-acp.yaml |
Widens the compatibility range and documents the validation requirement for future widening. |
examples/codex-acp-set/codex-acp-set.yaml |
Updates the Codex mixin reference and set version. |
cmd/frontend/examples_set_test.go |
Tests the revised compatibility boundaries. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codex-acp2.5.0 declares@openai/codex ^0.165.0, so the adapter kit requirescodex >= 0.165.0, < 0.166.0and refuses the currentcodexandcodex-mixinkits (0.166.0). Upstream has no release or open PR that moves the dependency; the pending 2.6.0 release (agentclientprotocol/codex-acp#708) still declares^0.165.0.This widens the requirement to
< 0.167.0, movescodex-acp-setontocodex-mixin:0.166.0and bumps the set to 1.0.7, and updatesTestCodexACPExampleRequiresCompatibleCodexso 0.166.x is accepted and 0.167.0 is the first refused version.Validation
Composed
docker/sbx-kit-shell:1.0.0+docker/sbx-kit-codex-mixin:0.166.0+ this branch'scodex-acpinsbxon macOS arm64 with an OpenAI OAuth credential, and drovecodex-acpover stdio. The same session ran againstcodex-mixin:0.165.0+ the publishedcodex-acp:2.5.0as the baseline.initialize,session/new(model list returned), andsession/promptstreaming a reply tostopReason: end_turnbehave the same on both, down to the token counts.Failed to publish available commands ... app-server exited with code 0. The agent is shutting down.from a commands refresh still in flight. Waiting before closing stdin, both versions publish oneavailable_commands_updateand exit cleanly, so this is a shutdown race rather than an incompatibility.task validateandtask test:unitpass.Publishing
The published
sbx-kit-codex-acp:2.5.0still carries the old range, so the set cannot build againstcodex-mixin:0.166.0until the adapter is republished. Order:codex-acp(2.5.0), thencodex-acp-set(1.0.7).Release note