Skip to content

feat: DH-24141: v3 console plan - #208

Merged
jnumainville merged 9 commits into
v3_rewritefrom
v3_console
Nov 4, 2026
Merged

jnumainville merged 9 commits into
v3_rewritefrom
v3_console

Conversation

@jnumainville

@jnumainville jnumainville commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator
  • Adds a minimal plan for consoles. No exec yet, which is tracked in a different ticket as it has additional nuances.
  • Adds refined and explicit strategies for failure handling, which will becomes increasingly important with consoles and is a significant pain point in v2 (especially in regards to timeout). The emphasis here is enabling agents to handle most of this with targeted feedback and simple options.

@jnumainville
jnumainville requested a balanced review from Copilot October 26, 2026 18:38
@jnumainville
jnumainville added this pull request to stack #204 October 26, 2026 18:38
@semanticdiff-com

semanticdiff-com Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review changes with  SemanticDiff

@jnumainville jnumainville changed the title feat: DH-24141: console plan feat: DH-24141: v3 console plan Oct 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Profile-reference identity and conflicting override persistence rules need clarification before implementation.

2 open issues
What changed in this PR

This documentation-only PR plans console management for the dh CLI and lightweight workspaces that isolate profile and console selections for projects and parallel agents. Script execution remains out of scope.

Changes:

  • Defines console commands, creation defaults, lifecycle behavior, and errors.
  • Specifies workspace resolution, copying, freezing, and selection persistence.
  • Outlines implementation stages and acceptance criteria.
File Description
plans/​console.md Adds the console and workspace design, implementation sequence, and completion checklist.

Review effort: Balanced

Comment thread plans/console.md Resolved
Comment thread plans/console.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The readiness rule must allow inspection and deletion of stopped or failed selected consoles.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Medium severity Allow show and destroy for stopped or failed consoles

plans/​console.md:102

The unconditional console_not_ready rule also applies to show and destroy without an explicit console, since both default to the console in use. This prevents inspecting or cleaning up a selected console after it stops or fails, despite those operations not needing a running console. Please distinguish console resolution from readiness validation and explicitly allow show and destroy for stopped/failed consoles.

2 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

This documentation-only plan has one non-blocking contract clarification and introduces no executable changes.

1 open issue

Review effort: Balanced

Comment thread plans/console.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only plan has no unresolved findings and introduces no executable changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The create retry contract needs an explicit attempt identifier to distinguish recovery from independent creates.

1 open issue

Review effort: Balanced

Comment thread plans/console.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

This documentation-only plan has no identified blocking issues and clearly separates new console creation from inspecting uncertain outcomes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@jnumainville
jnumainville marked this pull request as ready for review October 27, 2026 21:11

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@jnumainville
jnumainville requested a review from mofojed October 28, 2026 20:22
@jnumainville

Copy link
Copy Markdown
Collaborator Author

Oops, unintentional rerequest

Copilot AI balanced review requested due to automatic review settings October 29, 2026 22:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the documentation-only console-management design plan.

No open issues 🎉

Review effort: Balanced

@bmingles bmingles left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just left 1 clarification question

Comment thread plans/console.md
`DH_CONFIG_DIR`.
- Settings: `--language python|groovy`, `--heap-size-gb <n>`, `--server <name>`,
`--engine <name>`, or `--json '{…}'` for those plus `jvmArgs`, `environment`,
`autoDeleteTimeoutSeconds`. Per field: flag > `--json` > default.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "Per field: flag > --json > default" mean?

@jnumainville jnumainville Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the priority the args are used. So flag has higher priority than the same field in json which has priority higher than the default.

Base automatically changed from v3_auth to v3_rewrite November 4, 2026 18:46
Copilot AI balanced review requested due to automatic review settings November 4, 2026 18:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The plan places console actions in src/console/, conflicting with the architecture’s required src/actions/console/ layout.

1 open issue

Review effort: Balanced

Comment thread plans/console.md Resolved
Copilot AI balanced review requested due to automatic review settings November 4, 2026 18:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because shortcode mapping and subsequent detail authentication are undefined for environment-authenticated users without a saved profile.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@jnumainville

Copy link
Copy Markdown
Collaborator Author

No meaningful changes from the approved version. Going to go ahead and start on stack instead of addressing it all in this PR.

@jnumainville
jnumainville merged commit b490cca into v3_rewrite Nov 4, 2026
7 checks passed
@jnumainville
jnumainville deleted the v3_console branch November 4, 2026 19:21
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants