Skip to content

Centralize BMI stage execution and include bundled checks in coverage - #60

Merged
mcflugen merged 1 commit into
csdms:masterfrom
mcflugen:improve-bmi-example
Oct 16, 2026
Merged

mcflugen merged 1 commit into
csdms:masterfrom
mcflugen:improve-bmi-example

Conversation

@mcflugen

Copy link
Copy Markdown
Member

I've modified check_bmi to now run all of the checks by default. Previously, it only ran the bootstrap tests. This now matches the CLI behavior. There is also now an option to stop after the first stage failure, or to try to forge ahead.

I've also:

  • replaced BmiExample withUniformRectilinearBmi, which inherits from bmipy.Bmi.
  • confgured the coverage to report all bmi_tester source files—including the bundled tests (previously those were being left out of the coverage report)

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.10%. Comparing base (77c60f9) to head (82ad89e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   70.97%   70.10%   -0.88%     
==========================================
  Files           9       15       +6     
  Lines         317      659     +342     
==========================================
+ Hits          225      462     +237     
- Misses         92      197     +105     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcflugen
mcflugen force-pushed the improve-bmi-example branch 2 times, most recently from 33d0fc4 to 16a8b5f Compare October 16, 2026 23:06
@mcflugen
mcflugen force-pushed the improve-bmi-example branch from 16a8b5f to 82ad89e Compare October 16, 2026 23:13
@mcflugen
mcflugen merged commit 6babc1e into csdms:master Oct 16, 2026
21 of 22 checks passed
@mcflugen
mcflugen deleted the improve-bmi-example branch October 16, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant