Repository navigation
Centralize BMI stage execution and include bundled checks in coverage - #60
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 70.97% 70.10% -0.88%
==========================================
Files 9 15 +6
Lines 317 659 +342
==========================================
+ Hits 225 462 +237
- Misses 92 197 +105 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mcflugen
force-pushed
the
improve-bmi-example
branch
2 times, most recently
from
October 16, 2026 23:06
33d0fc4 to
16a8b5f
Compare
mcflugen
force-pushed
the
improve-bmi-example
branch
from
October 16, 2026 23:13
16a8b5f to
82ad89e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've modified
check_bmito now run all of the checks by default. Previously, it only ran the bootstrap tests. This now matches the CLI behavior. There is also now an option to stop after the first stage failure, or to try to forge ahead.I've also:
BmiExamplewithUniformRectilinearBmi, which inherits frombmipy.Bmi.bmi_testersource files—including the bundled tests (previously those were being left out of the coverage report)