Repository navigation
log dependency should not set release_max_level_debug feature (affects crate downstream users) #98
Description
cros-codecs declares log = { version = "0", features = ["release_max_level_debug"] } in its Cargo.toml. Because Cargo features are additive and global, this forces the release_max_level_debug setting on all downstream users, and conflicts with any application that sets a different release_max_level_*, causing a compile error:
error: multiple release_max_level_* features set
The log crate docs recommend that only final binaries set these features, not libraries (like cros_codecs).
I suggest fixing this by removing features = ["release_max_level_debug"] from the log dependency and let consuming applications decide their own log level filtering, as per the log crate's recommendations.
Activity
omelia-iliffe commentedon Oct 18, 2026
would be good to get a fix for this merged as the work around is forking and patching.
rosetta-jpn commentedon Oct 21, 2026
I apologize for not responding this for a long time. The patch LGTM. Let me merge.
rosetta-jpn commentedon Oct 21, 2026
@zhaop can you create a pull reuqest in this cros-codecs repository?
zhaop commentedon Oct 21, 2026
@rosetta-jpn Oops sorry, I didn't even realize I opened it against my own main.
Here is the PR on this repo: #103
rosetta-jpn commentedon Oct 21, 2026
Thanks @zhaop for creating PR. I merged it now.