Repository navigation
Remove redb::io, and make the Io error variants require std - #1638
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
cberner
force-pushed
the
claude/sweet-hypatia-m4vct7-backend-error-other
branch
from
November 8, 2026 19:49
65fe436 to
054f88b
Compare
cberner
force-pushed
the
claude/sweet-hypatia-m4vct7-remove-io
branch
from
November 8, 2026 19:49
4550996 to
50d0567
Compare
Base automatically changed from
claude/sweet-hypatia-m4vct7-backend-error-other
to
master
November 8, 2026 21:26
Without std, redb exposed a stand-in io::Error so that BackendError::Io had something to hold. Now that BackendError::Other can carry any error, the Io variants of BackendError, StorageError and Error, and their io::Error conversions, exist only with std and hold std::io::Error directly. The stand-in and the redb::io module are removed. All three enums are non_exhaustive, so the extra variant with std cannot break a downstream match. The no_std regression crate also checks that a backend's Other error reaches the caller. Assisted-by: Claude Code Claude-Session: https://claude.ai/code/session_01ALhxet6NP69dCfAUv8TAhR
cberner
force-pushed
the
claude/sweet-hypatia-m4vct7-remove-io
branch
from
November 8, 2026 21:26
50d0567 to
b0c1fbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of 3: removes
redb::io, following #1636 and #1637 (both merged). Rebased onto master; the tree is unchanged.Iovariants are std-only. TheIovariants ofBackendError,StorageErrorandError, and theirFrom<std::io::Error>/From<BackendError> for std::io::Errorimpls, now exist only with std (cfg(not(redb_no_std))). They holdstd::io::Errordirectly. All three enums are#[non_exhaustive], so a variant that appears when another crate turns on std can't break a downstreammatch. Withoutexperimental-api-5, std is always on, so 4.x users see no change.src/io.rsis deleted, along with the stand-inio::Errorand its tests. Without std, a backend reports failures withBackendError::Other(from Add BackendError::Other for backend failures that are not I/O errors #1637).invalid_input/invalid_datahelpers are now crate-private constructors onBackendError. With std they build the sameio::Errorkinds as before; without std the kind is dropped, as it was before.sync_datareturnsBackendError::Other, and checks thatcreate_with_backendreports it asStorageError::Backend.After this, the remaining flag-removal work for this area is mechanical: replace the
BackendIoErroralias from #1636 withBackendErrorand drop itsuseless_conversionallows.Checked:
cargo fmt.--all --all-targets, with and without--all-features, on Linux, Windows and macOS.logging.cargo checkfor wasm32-unknown-unknown (3 feature sets) and wasm32-wasip1.cargo doc.cargo test --all-features, andcargo testwith default features.🤖 Generated with Claude Code
https://claude.ai/code/session_01ALhxet6NP69dCfAUv8TAhR