Repository navigation
fix(repack-plugin-nativewind): configure SWC rules nested in oneOf - #1494
Merged
Merged
Conversation
NativeWindPlugin only updated top-level builtin:swc-loader rules, so with getJsTransformRules (which nests them in oneOf) JSX kept importing from `react`. Walk nested `oneOf` and `rules` as well. Related to callstack#1422
🦋 Changeset detectedLatest commit: 3564505 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@whydidoo is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
dannyhw
approved these changes
Oct 14, 2026
CristiCeban
approved these changes
Oct 15, 2026
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1422.
Summary
NativeWindPluginonly rewrotebuiltin:swc-loaderrules at the top level ofmodule.rules.getJsTransformRulesnests them inoneOf, soimportSource: 'nativewind'was never applied there and JSX kept importing fromreact.The walker lives inside the plugin, so
@callstack/repackgets no new public export. This part of the plugin is already marked "remove in 6.0".Test plan
tests/integration/src/plugins/NativeWindPlugin.test.ts(Rspack): withgetJsTransformRules()+NativeWindPlugin, everybuiltin:swc-loader, including those insideoneOf, getsimportSource: 'nativewind'. It was red before the change (react).