[leogdion]

The Swift Android SDK's bundled NDK sysroot for API 36 does not ship
crtbegin_dynamic.o / crtend_android.o, which the Swift toolchain still
asks ld.lld to link. That broke the Android leg of CI at API 36 (see
android/ndk#1391).

Rewrite the build-android matrix as a cross product of {Swift 6.3,
Swift 6.4-nightly} x {API 28, API 34}, moving the nightly's SDK URL and
ID onto the swift entry so the 6.3 rows leave them empty.

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_014j6vCW2JwTi3P9Sm6q2q4E

Summary by CodeRabbit

• Build and Compatibility
  • Updated Android build coverage to include Swift 6.3 and a Swift 6.4 development snapshot.
  • Adjusted supported Android API levels to 28 and 34.
  • Improved build matrix behavior so one failed configuration does not stop other builds.
• Testing
  • Updated Android coverage reporting labels to accurately identify Swift build variants.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7d315232-5c70-4068-b6f2-8a211783df5d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The Android CI matrix now includes updated Swift versions, a Swift 6.4.x development snapshot, Android API levels 28 and 34, and labeled Codecov flags. Matrix jobs no longer fail fast.

Changes

Android CI configuration

Layer / File(s)	Summary
Android build matrix and coverage flags .github/workflows/syndikit.yml	The build-android matrix adds Swift version metadata and a development snapshot SDK, updates Android API levels, disables fail-fast, and uses Swift labels for Codecov flags.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• brightdigit/SyndiKit#85: Both changes update the workflow’s Swift-version CI configuration.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main CI change: capping Android API level at 34 and adding Swift 6.3 plus 6.4-nightly coverage.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/syndikit-ci-cd-failure-23sliv

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[claude]

Review: ci(android): cap API level at 34 and cover Swift 6.3 + 6.4-nightly

Overview

Reworks the build-android job matrix in .github/workflows/syndikit.yml from {6.1, 6.2, 6.3} x {28, 33, 36} to {6.3, 6.4-nightly} x {28, 34}, dropping API 36 to work around a missing crtbegin_dynamic.o/crtend_android.o in the bundled NDK sysroot (android/ndk#1391), and adding fail-fast: false plus per-entry sdk-url/sdk-id overrides so the 6.4 nightly snapshot can be pulled in without affecting the 6.3 row.

Code quality & style

• The added comment explaining why API level is capped (linking the upstream NDK issue) is exactly the kind of non-obvious rationale CLAUDE.md asks for -- good call.
• Renaming the Codecov flag component from matrix.swift.version to matrix.swift.label is a nice touch -- using the raw nightly snapshot string (6.4.x-DEVELOPMENT-SNAPSHOT-...) as a flag would have been unwieldy/noisy in Codecov.
• The per-row sdk-url/sdk-id pattern mirrors the existing build-windows job's per-entry version/build matrix fields, so it's consistent with conventions already in this file.
• fail-fast: false is a good addition given the matrix now mixes a stable release with a nightly snapshot (a nightly failure shouldn't cancel the 6.3 rows) -- though it makes this job inconsistent with build-ubuntu/build-macos/build-windows, none of which set fail-fast. If mixing stable/nightly toolchains becomes a pattern elsewhere, worth applying consistently (or documenting why Android is the exception).

Potential issues / risks

• Reliance on empty-string fallback in brightdigit/swift-build: for the 6.3 matrix entry, sdk-url/sdk-id keys aren't defined, so matrix.swift.sdk-url / matrix.swift.sdk-id resolve to empty strings when interpolated into the with: block. This only works correctly if the composite action treats an empty-string input the same as "unset" and falls back to its built-in default SDK. Worth double-checking that action's input handling (or just confirming green CI on the 6.3 rows) rather than assuming it.
• Hard-pinned nightly snapshot: 6.4.x-DEVELOPMENT-SNAPSHOT-2026-06-15-a is a dated snapshot from the swift-6.4.x-branch. Nightly toolchain retention is limited, so this URL/ID will eventually go stale and start 404ing -- this pin will need periodic bumping (unlike the 6.3 row, which uses a stable, long-lived release). Might be worth a tracking issue/reminder, or checking whether the tooling supports "latest nightly" resolution instead of a hard-coded date.
• Coverage reduction: dropping Swift 6.1/6.2 from the Android matrix (previously tested) in favor of 6.3/6.4-nightly is a bigger scope change than "cap API level" alone -- reasonable given the PR's goal, but worth calling out explicitly in the description since it changes what's actually verified on Android, not just which API levels.
• CLAUDE.md is now further out of date: the CI section says "Android: API levels 28, 33, 34 with Swift 6.1" -- already stale before this PR (the workflow tested 6.1/6.2/6.3 x 28/33/36), and now more so (6.3/6.4-nightly x 28/34). Not a blocker, but worth a follow-up doc update so CLAUDE.md stays a reliable reference for future contributors/agents.

Test coverage

Pure CI-configuration change -- no app/library test coverage implications. The real verification is the workflow run itself; worth confirming the build-android job goes green on both the 6.3 and 6.4-nightly rows (especially the 6.3 row's SDK default fallback mentioned above) before merging.

Security considerations

No security concerns -- the nightly artifact is still fetched from the trusted download.swift.org host, same as the existing pattern elsewhere in the workflow.

---

Overall this is a well-scoped, well-justified CI fix with a clear upstream reference for the root cause. Main follow-ups worth considering: confirm the empty-string SDK override behaves as expected, and note that the nightly pin will need periodic maintenance.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/syndikit.yml:
- Around line 306-309: Update the nightly Android matrix entries around the
Swift 6.4 snapshot and the corresponding swift-build invocation to define a
non-empty android-sdk-target whenever android-sdk-url is configured, then
forward that matrix value through swift-build alongside the existing SDK URL and
SDK ID inputs.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 38c14ec4-64ef-4e72-967b-f4049b44472d

📥 Commits

Reviewing files that changed from the base of the PR and between 746262a and 31243b0.

📒 Files selected for processing (1)

• .github/workflows/syndikit.yml

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

curl -fsSL https://raw.githubusercontent.com/brightdigit/swift-build/v1/action.yml \
  | grep -A12 -B4 'android-sdk-target'

curl -fsSL https://raw.githubusercontent.com/skiptools/swift-android-action/main/action.yml \
  | grep -A8 -B4 "custom-sdk-id.*installed-sdk"

curl -fsSI \
  "https://download.swift.org/swift-6.4.x-branch/android-sdk/swift-6.4.x-DEVELOPMENT-SNAPSHOT-2026-06-15-a/swift-6.4.x-DEVELOPMENT-SNAPSHOT-2026-06-15-a_android.artifactbundle.tar.gz"

Repository: brightdigit/SyndiKit

Length of output: 4046

---

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

# Inspect the relevant workflow sections with line numbers.
sed -n '290,345p' .github/workflows/syndikit.yml | cat -n

# Pull the downstream action contract sections that mention Android SDK inputs.
curl -fsSL https://raw.githubusercontent.com/brightdigit/swift-build/v1/action.yml \
  | sed -n '1,220p' | grep -n -A6 -B4 'android-sdk-target\|custom-sdk-url\|installed-sdk\|custom-sdk-id'

# Also inspect the setup logic that consumes these inputs.
curl -fsSL https://raw.githubusercontent.com/brightdigit/swift-build/v1/action.yml \
  | grep -n -A12 -B6 'installed-sdk: \${{'

Repository: brightdigit/SyndiKit

Length of output: 232

---

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

python3 - <<'PY'
import re, urllib.request

url = "https://raw.githubusercontent.com/brightdigit/swift-build/v1/action.yml"
text = urllib.request.urlopen(url, timeout=20).read().decode()
for key in ["android-sdk-target", "custom-sdk-url", "custom-sdk-id", "installed-sdk"]:
    print(f"\n## {key}")
    for m in re.finditer(key, text):
        start = max(0, m.start()-180)
        end = min(len(text), m.end()+260)
        print(text[start:end].replace("\r",""))
        print("----")
        break
PY

Repository: brightdigit/SyndiKit

Length of output: 2444

---

Pass android-sdk-target through the nightly Android builds
The custom SDK inputs require a non-empty target whenever android-sdk-url is set, so add the target to the matrix entry and forward it to swift-build at lines 306-309 and 333-334.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/syndikit.yml around lines 306 - 309, Update the nightly
Android matrix entries around the Swift 6.4 snapshot and the corresponding
swift-build invocation to define a non-empty android-sdk-target whenever
android-sdk-url is configured, then forward that matrix value through
swift-build alongside the existing SDK URL and SDK ID inputs.

[claude]

Review

This is a clean, well-scoped fix for the Android CI matrix — the NDK API 36 crtbegin_dynamic.o/crtend_android.o issue is documented with a link, and collapsing the three explicit include rows into a swift × android-api-level cross product removes a fair bit of duplication while keeping the SDK URL/ID cleanly scoped to the 6.4 entry.

One behavior change worth double-checking, though:

android-run-tests is now unconditionally true for all 4 matrix legs. In the old matrix, only the 6.3 / API 28 row set android-run-tests: true — the other two rows (6.3/36 and the 6.4-nightly/36) left it unset, i.e. build-only (per the old comment: "Swift 6.4 (nightly snapshot SDK bundle, api 34, build only)"). This PR now runs the full test suite (with emulator boot) on all 4 combinations, including both API levels of the Swift 6.4 nightly snapshot. That's a meaningful jump from 1 test-running leg to 4, and it means CI correctness now depends on the nightly toolchain passing the test suite, not just building — which is a more flake-prone bar than what was there before. Neither the PR description nor the commit message mentions this as an intended change (they only talk about the API-level fix), so it may be an incidental side effect of the matrix restructuring rather than a deliberate decision. Worth confirming: if build-only was intentional for the nightly leg to avoid emulator flakiness dragging down full-matrix CI, it'd be worth keeping android-run-tests scoped per-row (e.g. only true for the 6.3 entries, or only for one API level) rather than blanket enabling it.

Minor / docs drift: CLAUDE.md's CI/CD section still says "Android: Swift 6.3 (API 28/36) and Swift 6.4 nightly snapshot (API 36)" — after this change the API levels are 28/34, not 28/36. Since the repo convention documents CI structure there, it'd be good to update that line alongside this PR (or as an immediate follow-up) so it doesn't go stale.

No code/logic changes, no test coverage implications beyond CI itself, and no security concerns — this is a workflow-only diff.

[claude]

Review: ci(android) — cap API level at 34, cover Swift 6.3 + 6.4-nightly

Clean, well-motivated refactor. The move from a hand-enumerated include: list to a swift object list × android-api-level: [28, 34] cross product is the right structural fix, and pinning the SDK URL/ID onto the swift entry (rather than repeating them per row) correctly lets swift-build's blank-input handling do the work for 6.3. The inline comment explaining why API 36 is skipped (linking the upstream NDK issue) is exactly the kind of non-obvious context worth keeping in-repo.

One thing worth double-checking before merge:

android-run-tests: true is now unconditional, silently expanding test execution to 3 new legs.
In the old matrix, only the 6.3/API 28 entry set android-run-tests: true; the 6.3/API 36 and 6.4-nightly/API 36 entries omitted it (build-only). After hoisting the field out of the matrix into the shared step body (.github/workflows/SyndiKit.yml:296), it now applies to all four combinations — including both API levels on the Swift 6.4 nightly snapshot. That's a real behavior change (tests now run against a nightly toolchain, 2x over) that isn't mentioned in the PR description, which frames this purely as a matrix-shape/API-level fix. Nightly snapshots are typically the flakier leg elsewhere in this workflow (e.g. the wasm/Ubuntu nightly builds stay build-only) — was running tests against 6.4-nightly here intentional, or should it stay build-only like before to avoid new flaky-CI noise on main?

Minor: CLAUDE.md CI section is now stale.
The CI/CD section of CLAUDE.md documents Android as "Swift 6.3 (API 28/36) and Swift 6.4 nightly snapshot (API 36)". Since this PR changes the matrix shape to a 6.3/6.4 × 28/34 cross product, that line should be updated in the same PR so the doc doesn't drift from the workflow it's describing.

No functional/security concerns — this is workflow-only config, and the trailing-whitespace cleanup in the removed android-copy-files lines is a nice bonus. Nothing to test at the unit-test level here beyond an actual CI run confirming the API 36 legs are gone and the four new legs go green.

[claude]

Review

Clean, well-scoped change — single file, and the new cross-product matrix (swift × android-api-level) is much easier to reason about than the old include: list. The comment update clearly documents the API 36 NDK issue with a link, which is great for future maintainers.

Things worth confirming

1. android-run-tests is now unconditionally true for all 4 combinations. Previously, only Swift 6.3 / API 28 ran tests — the other two entries (6.3/API 36 and the 6.4-nightly/API 36) were build-only (no android-run-tests key set). With the new matrix, tests now execute on all four combos, including the 6.4 nightly-snapshot toolchain and API 34. That's arguably a nice coverage improvement, but it's also a behavior change beyond "cap API level at 34" — it roughly doubles the number of test executions and adds test runs on a nightly Swift snapshot, which could introduce flakiness or added CI time that wasn't there before. Worth a sentence confirming this expansion is intentional (the PR description doesn't call it out).

2. CLAUDE.md's CI/CD section is now stale. It documents **Android**: Swift 6.3 (API 28/36) and Swift 6.4 nightly snapshot (API 36), which no longer matches this PR's 6.3/6.4 × API 28/34 cross product. Since this file is the canonical guidance doc for the CI matrix shape, it'd be good to update it alongside this change (or as an immediate follow-up) so it doesn't drift from the actual workflow.

3. Nested matrix property access (matrix.swift.sdk-url, matrix.swift.sdk-id, matrix.swift.label) — the file already proves hyphenated flat matrix keys work fine in GH Actions expressions (e.g. matrix.android-swift-version previously), but this is the first use of a hyphenated key nested inside an object-valued matrix entry in this workflow. Should be low-risk, but worth keeping an eye on the first CI run to confirm the 6.3 rows correctly resolve sdk-url/sdk-id to empty/blank (relying on "blank inputs are ignored by swift-build") rather than a literal null/undefined string.

Nit

The old android-copy-files: "Data/" entries had trailing whitespace that's cleaned up by this change — nice incidental fix.

No functional source changes in this PR (workflow-only), so most of code quality/test coverage/security categories don't apply here beyond the CI config itself.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.07%. Comparing base (516bb01) to head (16ca705).

Additional details and impacted files

@@                   Coverage Diff                   @@
##           brightdigit-com-260621     #131   +/-   ##
=======================================================
  Coverage                   79.07%   79.07%           
=======================================================
  Files                          74       74           
  Lines                        1553     1553           
=======================================================
  Hits                         1228     1228           
  Misses                        325      325           

Flag	Coverage Δ
5.10	66.06% <ø> (ø)
6.0	78.30% <ø> (ø)
6.1	78.30% <ø> (ø)
6.2	78.30% <ø> (?)
6.3	78.30% <ø> (ø)
ios18.5	78.30% <ø> (ø)
jammy	79.07% <ø> (ø)
macos	78.30% <ø> (ø)
macos-15	78.30% <ø> (ø)
macos-26	78.30% <ø> (ø)
noble	79.07% <ø> (ø)
spm	79.07% <ø> (ø)
tvos18.5	78.30% <ø> (ø)
tvos26.4	78.30% <ø> (ø)
visionos2.5	78.30% <ø> (ø)
watchos11.5	78.30% <ø> (ø)
watchos26.4	78.30% <ø> (ø)
xcode-27	78.36% <ø> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.