Skip to content

feat(boxsdkgen): add verificationMethod union to BoxSign signer schemas (box/box-openapi#626) - #1690

Merged
box-sdk-build merged 1 commit into
combined-sdkfrom
codegen-1701-0068c55-33e4656
Nov 9, 2026
Merged

box-sdk-build merged 1 commit into
combined-sdkfrom
codegen-1701-0068c55-33e4656

Conversation

@box-sdk-build

Copy link
Copy Markdown
Contributor

No description provided.

@box-sdk-build
box-sdk-build requested a review from a team November 9, 2026 16:20
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 42653751109

Warning

No base build found for commit 045bd27 on combined-sdk.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 15.975%

Details

  • Patch coverage: 186 uncovered changes across 12 files (80 of 266 lines covered, 30.08%).

Uncovered Changes

Top 10 Files by Coverage Impact Changed Covered %
src/sdk-gen/schemas/signRequestSignerVerificationMethodPhoneSms.ts 43 10 23.26%
src/sdk-gen/schemas/signRequestSignerVerificationMethodCacPiv.ts 30 9 30.0%
src/sdk-gen/schemas/signRequestSignerVerificationMethodLogin.ts 30 9 30.0%
src/sdk-gen/schemas/templateSignerVerificationMethodCacPiv.ts 30 9 30.0%
src/sdk-gen/schemas/templateSignerVerificationMethodLogin.ts 30 9 30.0%
src/sdk-gen/schemas/templateSignerVerificationMethodPhoneSms.ts 30 9 30.0%
src/sdk-gen/schemas/signRequestSignerVerificationMethod.ts 26 10 38.46%
src/sdk-gen/schemas/templateSignerVerificationMethod.ts 26 10 38.46%
src/sdk-gen/schemas/index.ts 13 0 0.0%
src/sdk-gen/schemas/signRequestCreateSigner.ts 3 2 66.67%
Total (12 files) 266 80 30.08%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 45424
Covered Lines: 11702
Line Coverage: 25.76%
Relevant Branches: 35539
Covered Branches: 1232
Branch Coverage: 3.47%
Branches in Coverage %: Yes
Coverage Strength: 107.88 hits per line

💛 - Coveralls

@box-sdk-build

Copy link
Copy Markdown
Contributor Author

Approved by @lsocha via codegen fan-out tool.

@box-sdk-build
box-sdk-build merged commit 04713d4 into combined-sdk Nov 9, 2026
13 checks passed
@box-sdk-build
box-sdk-build deleted the codegen-1701-0068c55-33e4656 branch November 9, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants