Skip to content

Pin the template to v1.0.0 and note the pre-release exception - #15

Merged
harikt merged 1 commit into
masterfrom
pin-template
Sep 8, 2026
Merged

harikt merged 1 commit into
masterfrom
pin-template

Conversation

@harikt

@harikt harikt commented Sep 8, 2026

Copy link
Copy Markdown
Member

Two fixes to templates/package-release.yml, the file packages copy when they adopt the shared release workflow.

Pin the uses: reference. It pointed at @master, so a change to the shared workflow reached every package's release path with no change on their side — and that workflow receives contents: write and creates tags. CodeRabbit flagged this on auraphp/Aura.Auth#119. The repo is now tagged v1.0.0 and the template points there; tracking master is still available, but as a deliberate opt-in rather than the default.

Matching PRs are open on the packages already using it: auraphp/Aura.Html#79, auraphp/Aura.View#98, auraphp/Aura.Session#106, auraphp/Aura.Session_Interface#2, and auraphp/Aura.Auth#119.

Fix the change log instruction. It said the version typed must match the version at the top of the change log. That is not the whole rule — the workflow also accepts a pre-release against its base version, so 7.0.0-beta1 releases fine against a ## 7.0.0 heading. That is exactly how aura/session-interface was just released. The narrower claim was being inherited by every package copied from this template; the same correction already landed in auraphp/Aura.Html#75.

🤖 Generated with Claude Code

The uses: line pointed at @master, so a change to the shared workflow would
reach every package's release path with no change on their side -- and that
workflow gets contents: write and creates tags. It now points at the v1.0.0
tag; tracking master is still available, but as an opt-in.

The change log instruction said the version must match the top heading. A
pre-release is also accepted against its base version, so 7.0.0-beta1 works
with a '## 7.0.0' heading. Packages copied from this template were inheriting
the narrower claim.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 217c3fe6-0902-4c31-a30a-461018444a9a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harikt
harikt merged commit bd2b71d into master Sep 8, 2026
1 check passed
@harikt
harikt deleted the pin-template branch September 8, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant