Repository navigation
Pin the template to v1.0.0 and note the pre-release exception - #15
Merged
Merged
Conversation
The uses: line pointed at @master, so a change to the shared workflow would reach every package's release path with no change on their side -- and that workflow gets contents: write and creates tags. It now points at the v1.0.0 tag; tracking master is still available, but as an opt-in. The change log instruction said the version must match the top heading. A pre-release is also accepted against its base version, so 7.0.0-beta1 works with a '## 7.0.0' heading. Packages copied from this template were inheriting the narrower claim.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to
templates/package-release.yml, the file packages copy when they adopt the shared release workflow.Pin the
uses:reference. It pointed at@master, so a change to the shared workflow reached every package's release path with no change on their side — and that workflow receivescontents: writeand creates tags. CodeRabbit flagged this on auraphp/Aura.Auth#119. The repo is now taggedv1.0.0and the template points there; trackingmasteris still available, but as a deliberate opt-in rather than the default.Matching PRs are open on the packages already using it: auraphp/Aura.Html#79, auraphp/Aura.View#98, auraphp/Aura.Session#106, auraphp/Aura.Session_Interface#2, and auraphp/Aura.Auth#119.
Fix the change log instruction. It said the version typed must match the version at the top of the change log. That is not the whole rule — the workflow also accepts a pre-release against its base version, so
7.0.0-beta1releases fine against a## 7.0.0heading. That is exactly howaura/session-interfacewas just released. The narrower claim was being inherited by every package copied from this template; the same correction already landed in auraphp/Aura.Html#75.🤖 Generated with Claude Code